| Message ID | 20160707033837.20029-1-khilman@baylibre.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
Quoting Kevin Hilman (2016-07-06 20:38:37) > The MMC_PCLK is needed for the SD/eMMC driver, expose to DT (and comment > out in clk driver) > > Signed-off-by: Kevin Hilman <khilman@baylibre.com> Applied to the same clk-s905 branch if you need to re-pull it as a dependency. Regards, Mike > --- > drivers/clk/meson/gxbb.h | 2 +- > include/dt-bindings/clock/gxbb-clkc.h | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/clk/meson/gxbb.h b/drivers/clk/meson/gxbb.h > index a2adf3448b59..8355ecd27b81 100644 > --- a/drivers/clk/meson/gxbb.h > +++ b/drivers/clk/meson/gxbb.h > @@ -234,7 +234,7 @@ > #define CLKID_HDMI_PCLK 63 > #define CLKID_USB1_DDR_BRIDGE 64 > #define CLKID_USB0_DDR_BRIDGE 65 > -#define CLKID_MMC_PCLK 66 > +/* CLKID_MMC_PCLK */ > #define CLKID_DVIN 67 > #define CLKID_UART2 68 > #define CLKID_SANA 69 > diff --git a/include/dt-bindings/clock/gxbb-clkc.h b/include/dt-bindings/clock/gxbb-clkc.h > index f889d80246cb..5eb69ec74f6b 100644 > --- a/include/dt-bindings/clock/gxbb-clkc.h > +++ b/include/dt-bindings/clock/gxbb-clkc.h > @@ -8,5 +8,6 @@ > #define CLKID_CPUCLK 1 > #define CLKID_CLK81 12 > #define CLKID_ETH 36 > +#define CLKID_MMC_PCLK 66 > > #endif /* __GXBB_CLKC_H */ > -- > 2.9.0 >
Michael Turquette <mturquette@baylibre.com> writes: > Quoting Kevin Hilman (2016-07-06 20:38:37) >> The MMC_PCLK is needed for the SD/eMMC driver, expose to DT (and comment >> out in clk driver) >> >> Signed-off-by: Kevin Hilman <khilman@baylibre.com> > > Applied to the same clk-s905 branch if you need to re-pull it as a > dependency. Ugh. Just received some updated documentation, and turns out this clock is not used at all. :( Feel free to revert now before it becomes ABI. Now that I have actual docs, I'll have a new series coming that will have the right clock details. Thanks, and sorry for the noise, Kevin
Quoting Kevin Hilman (2016-07-15 09:48:30) > Michael Turquette <mturquette@baylibre.com> writes: > > > Quoting Kevin Hilman (2016-07-06 20:38:37) > >> The MMC_PCLK is needed for the SD/eMMC driver, expose to DT (and comment > >> out in clk driver) > >> > >> Signed-off-by: Kevin Hilman <khilman@baylibre.com> > > > > Applied to the same clk-s905 branch if you need to re-pull it as a > > dependency. > > Ugh. Just received some updated documentation, and turns out this clock > is not used at all. :( > > Feel free to revert now before it becomes ABI. Reverted. > > Now that I have actual docs, I'll have a new series coming that will > have the right clock details. No problem. I did a git revert b/c I don't want to rebase this late in the cycle. Regards, Mike > > Thanks, and sorry for the noise, > > Kevin
diff --git a/drivers/clk/meson/gxbb.h b/drivers/clk/meson/gxbb.h index a2adf3448b59..8355ecd27b81 100644 --- a/drivers/clk/meson/gxbb.h +++ b/drivers/clk/meson/gxbb.h @@ -234,7 +234,7 @@ #define CLKID_HDMI_PCLK 63 #define CLKID_USB1_DDR_BRIDGE 64 #define CLKID_USB0_DDR_BRIDGE 65 -#define CLKID_MMC_PCLK 66 +/* CLKID_MMC_PCLK */ #define CLKID_DVIN 67 #define CLKID_UART2 68 #define CLKID_SANA 69 diff --git a/include/dt-bindings/clock/gxbb-clkc.h b/include/dt-bindings/clock/gxbb-clkc.h index f889d80246cb..5eb69ec74f6b 100644 --- a/include/dt-bindings/clock/gxbb-clkc.h +++ b/include/dt-bindings/clock/gxbb-clkc.h @@ -8,5 +8,6 @@ #define CLKID_CPUCLK 1 #define CLKID_CLK81 12 #define CLKID_ETH 36 +#define CLKID_MMC_PCLK 66 #endif /* __GXBB_CLKC_H */
The MMC_PCLK is needed for the SD/eMMC driver, expose to DT (and comment out in clk driver) Signed-off-by: Kevin Hilman <khilman@baylibre.com> --- drivers/clk/meson/gxbb.h | 2 +- include/dt-bindings/clock/gxbb-clkc.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-)