| Message ID | 20160717105208.9596-2-bshah@kde.org (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Sun 17 Jul 03:52 PDT 2016, Bhushan Shah wrote: [..] > diff --git a/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts b/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts > new file mode 100644 > index 0000000..88d494f > --- /dev/null > +++ b/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts > @@ -0,0 +1,25 @@ > +#include "qcom-msm8974.dtsi" > +#include "qcom-pm8841.dtsi" > +#include "qcom-pm8941.dtsi" > + > +/ { > + model = "LGE MSM 8974 HAMMERHEAD"; > + compatible = "qcom,msm8974"; We should have a "lg,hammerhead" here as well, prior to "qcom,msm8974". Preferably some sort of "product family" definition, if we know of any to reduce the risk of conflicts with any other hammerheads from LGE. > + qcom,msm-id = <126 150 0x20002 0xB>; We've decided against defining qcom,msm-id in the dts files, so please drop this. Instead use dtbTool from git://codeaurora.org/quic/kernel/skales which should inject the correct information based on the compatible. > + > + aliases { > + serial0 = &blsp1_uart1; > + }; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > +}; > + > +&soc { > + As you're dropping msm-id, please also drop this empty line. > + serial@f991d000 { > + status = "ok"; > + }; > + Dito. > +}; Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile index 414b427..13947ec 100644 --- a/arch/arm/boot/dts/Makefile +++ b/arch/arm/boot/dts/Makefile @@ -584,6 +584,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \ qcom-ipq8064-ap148.dtb \ qcom-msm8660-surf.dtb \ qcom-msm8960-cdp.dtb \ + qcom-msm8974-lge-nexus5-hammerhead.dtb \ qcom-msm8974-sony-xperia-honami.dtb dtb-$(CONFIG_ARCH_REALVIEW) += \ arm-realview-pb1176.dtb \ diff --git a/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts b/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts new file mode 100644 index 0000000..88d494f --- /dev/null +++ b/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts @@ -0,0 +1,25 @@ +#include "qcom-msm8974.dtsi" +#include "qcom-pm8841.dtsi" +#include "qcom-pm8941.dtsi" + +/ { + model = "LGE MSM 8974 HAMMERHEAD"; + compatible = "qcom,msm8974"; + qcom,msm-id = <126 150 0x20002 0xB>; + + aliases { + serial0 = &blsp1_uart1; + }; + + chosen { + stdout-path = "serial0:115200n8"; + }; +}; + +&soc { + + serial@f991d000 { + status = "ok"; + }; + +};
This DTS file have support LG Nexus 5 (codenamed hammerhead). Initial version have support for just serial console over headphone jack. Cc: Andy Gross <andy.gross@linaro.org> Cc: Bjorn Andersson <bjorn.andersson@linaro.org> Cc: David Brown <david.brown@linaro.org> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Rob Herring <robh+dt@kernel.org> Cc: Russell King <linux@armlinux.org.uk> Cc: devicetree@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-arm-msm@vger.kernel.org Signed-off-by: Bhushan Shah <bshah@kde.org> --- arch/arm/boot/dts/Makefile | 1 + .../dts/qcom-msm8974-lge-nexus5-hammerhead.dts | 25 ++++++++++++++++++++++ 2 files changed, 26 insertions(+) create mode 100644 arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts