| Message ID | 1468302104-15288-1-git-send-email-yangx.jy@cn.fujitsu.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Jul 12, 2016 at 01:41:44PM +0800, Xiao Yang wrote: > xfs/083 will corrupt the fs intentionally, there will be WARNINGs > in dmesg as expected, so here disable dmesg check. > > Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com> > --- > tests/xfs/083 | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/tests/xfs/083 b/tests/xfs/083 > index d897754..040f3b6 100755 > --- a/tests/xfs/083 > +++ b/tests/xfs/083 > @@ -102,6 +102,10 @@ scratch_repair() { > } > > rm -f $seqres.full > +# This test will corrupt fs intentionally, so there will be WARNINGs > +# in dmesg as expected > +_disable_dmesg_check > + This looks fine to me, but I'd like Darrick to review it as well :) Thanks, Eryu > echo "See interesting results in $seqres.full" | sed -e "s,$RESULT_DIR,RESULT_DIR,g" > SRCDIR=`pwd` > test -z "${FUZZ_ARGS}" && FUZZ_ARGS="-3 -n 32" > -- > 1.8.3.1 > > > > -- > To unsubscribe from this list: send the line "unsubscribe fstests" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Jul 13, 2016 at 12:25:55PM +0800, Eryu Guan wrote: > On Tue, Jul 12, 2016 at 01:41:44PM +0800, Xiao Yang wrote: > > xfs/083 will corrupt the fs intentionally, there will be WARNINGs > > in dmesg as expected, so here disable dmesg check. > > > > Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com> > > --- > > tests/xfs/083 | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/tests/xfs/083 b/tests/xfs/083 > > index d897754..040f3b6 100755 > > --- a/tests/xfs/083 > > +++ b/tests/xfs/083 > > @@ -102,6 +102,10 @@ scratch_repair() { > > } > > > > rm -f $seqres.full > > +# This test will corrupt fs intentionally, so there will be WARNINGs > > +# in dmesg as expected > > +_disable_dmesg_check > > + > > This looks fine to me, but I'd like Darrick to review it as well :) I really want to know which WARN_ON they're hitting -- if the FS is corrupt, XFS should be returning -EFSCORRUPTED, which doesn't trigger warnings. (I suspect it's the warning that gets printed when corrupt inodes are found...) --D > > Thanks, > Eryu > > > echo "See interesting results in $seqres.full" | sed -e "s,$RESULT_DIR,RESULT_DIR,g" > > SRCDIR=`pwd` > > test -z "${FUZZ_ARGS}" && FUZZ_ARGS="-3 -n 32" > > -- > > 1.8.3.1 > > > > > > > > -- > > To unsubscribe from this list: send the line "unsubscribe fstests" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Jul 13, 2016 at 12:25:55PM +0800, Eryu Guan wrote: > On Tue, Jul 12, 2016 at 01:41:44PM +0800, Xiao Yang wrote: > > xfs/083 will corrupt the fs intentionally, there will be WARNINGs > > in dmesg as expected, so here disable dmesg check. > > > > Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com> > > --- > > tests/xfs/083 | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/tests/xfs/083 b/tests/xfs/083 > > index d897754..040f3b6 100755 > > --- a/tests/xfs/083 > > +++ b/tests/xfs/083 > > @@ -102,6 +102,10 @@ scratch_repair() { > > } > > > > rm -f $seqres.full > > +# This test will corrupt fs intentionally, so there will be WARNINGs > > +# in dmesg as expected > > +_disable_dmesg_check > > + > > This looks fine to me, but I'd like Darrick to review it as well :) I'm convinced, so Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com> --D > > Thanks, > Eryu > > > echo "See interesting results in $seqres.full" | sed -e "s,$RESULT_DIR,RESULT_DIR,g" > > SRCDIR=`pwd` > > test -z "${FUZZ_ARGS}" && FUZZ_ARGS="-3 -n 32" > > -- > > 1.8.3.1 > > > > > > > > -- > > To unsubscribe from this list: send the line "unsubscribe fstests" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/tests/xfs/083 b/tests/xfs/083 index d897754..040f3b6 100755 --- a/tests/xfs/083 +++ b/tests/xfs/083 @@ -102,6 +102,10 @@ scratch_repair() { } rm -f $seqres.full +# This test will corrupt fs intentionally, so there will be WARNINGs +# in dmesg as expected +_disable_dmesg_check + echo "See interesting results in $seqres.full" | sed -e "s,$RESULT_DIR,RESULT_DIR,g" SRCDIR=`pwd` test -z "${FUZZ_ARGS}" && FUZZ_ARGS="-3 -n 32"
xfs/083 will corrupt the fs intentionally, there will be WARNINGs in dmesg as expected, so here disable dmesg check. Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com> --- tests/xfs/083 | 4 ++++ 1 file changed, 4 insertions(+)