hwmon-ntc_thermistor: Delete an unnecessary check before the function call "iio_channel_release"

Commit Message

SF Markus Elfring July 18, 2016, 6:54 p.m. UTC

From: Markus Elfring <[e-mail]>
Date: Mon, 18 Jul 2016 20:34:41 +0200

The iio_channel_release() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[e-mail]>
---
 drivers/hwmon/ntc_thermistor.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Guenter Roeck July 19, 2016, 3:35 a.m. UTC | #1

On 07/18/2016 11:54 AM, SF Markus Elfring wrote:
> From: Markus Elfring <[e-mail]>
> Date: Mon, 18 Jul 2016 20:34:41 +0200
>
> The iio_channel_release() function tests whether its argument is NULL
> and then returns immediately. Thus the test around the call is not needed.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <[e-mail]>

A much better change would be to use devm_iio_channel_get() instead of
iio_channel_get(), and to remove ntc_iio_channel_release() completely.

Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/hwmon/ntc_thermistor.c b/drivers/hwmon/ntc_thermistor.c
index 8ef7b71..100878a 100644
--- a/drivers/hwmon/ntc_thermistor.c
+++ b/drivers/hwmon/ntc_thermistor.c
@@ -361,8 +361,7 @@  ntc_thermistor_parse_dt(struct platform_device *pdev)
 }
 static void ntc_iio_channel_release(struct ntc_thermistor_platform_data *pdata)
 {
-	if (pdata->chan)
-		iio_channel_release(pdata->chan);
+	iio_channel_release(pdata->chan);
 }
 #else
 static struct ntc_thermistor_platform_data *