| Message ID | 1468943818-26025-2-git-send-email-andi.shyti@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Jul 20, 2016 at 12:56:52AM +0900, Andi Shyti wrote: > The driver type can be assigned immediately when an RC device > requests to the framework to allocate the device. > > This is an 'enum rc_driver_type' data type and specifies whether > the device is a raw receiver or scancode receiver. The type will > be given as parameter to the rc_allocate_device device. This patch is good, but it does unfortunately break all the other rc-core drivers, as now rc_allocate_device() needs argument. All drivers will need a simple change in this patch. Also note that there lots of issues that checkpatch.pl would pick in these series. > > Suggested-by: Sean Young <sean@mess.org> > Signed-off-by: Andi Shyti <andi.shyti@samsung.com> > --- > drivers/media/rc/rc-main.c | 4 +++- > include/media/rc-core.h | 2 +- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc-main.c > index 7dfc7c2..6403674 100644 > --- a/drivers/media/rc/rc-main.c > +++ b/drivers/media/rc/rc-main.c > @@ -1346,7 +1346,7 @@ static struct device_type rc_dev_type = { > .uevent = rc_dev_uevent, > }; > > -struct rc_dev *rc_allocate_device(void) > +struct rc_dev *rc_allocate_device(enum rc_driver_type type) > { > struct rc_dev *dev; > > @@ -1373,6 +1373,8 @@ struct rc_dev *rc_allocate_device(void) > dev->dev.class = &rc_class; > device_initialize(&dev->dev); > > + dev->driver_type = type; > + > __module_get(THIS_MODULE); > return dev; > } > diff --git a/include/media/rc-core.h b/include/media/rc-core.h > index b6586a9..c6bf1ef 100644 > --- a/include/media/rc-core.h > +++ b/include/media/rc-core.h > @@ -185,7 +185,7 @@ struct rc_dev { > * Remote Controller, at sys/class/rc. > */ > > -struct rc_dev *rc_allocate_device(void); > +struct rc_dev *rc_allocate_device(enum rc_driver_type); > void rc_free_device(struct rc_dev *dev); > int rc_register_device(struct rc_dev *dev); > void rc_unregister_device(struct rc_dev *dev); > -- > 2.8.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Sean, > > The driver type can be assigned immediately when an RC device > > requests to the framework to allocate the device. > > > > This is an 'enum rc_driver_type' data type and specifies whether > > the device is a raw receiver or scancode receiver. The type will > > be given as parameter to the rc_allocate_device device. > > This patch is good, but it does unfortunately break all the other > rc-core drivers, as now rc_allocate_device() needs argument. All > drivers will need a simple change in this patch. Yes, but for being an RFC I didn't took care of fixing everything. > Also note that there lots of issues that checkpatch.pl would pick > in these series. Some of the issues are coming from the code as it was and I preferred to not change it. The last patch has some that need to be fixed in the patchset. Thanks, Andi -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc-main.c index 7dfc7c2..6403674 100644 --- a/drivers/media/rc/rc-main.c +++ b/drivers/media/rc/rc-main.c @@ -1346,7 +1346,7 @@ static struct device_type rc_dev_type = { .uevent = rc_dev_uevent, }; -struct rc_dev *rc_allocate_device(void) +struct rc_dev *rc_allocate_device(enum rc_driver_type type) { struct rc_dev *dev; @@ -1373,6 +1373,8 @@ struct rc_dev *rc_allocate_device(void) dev->dev.class = &rc_class; device_initialize(&dev->dev); + dev->driver_type = type; + __module_get(THIS_MODULE); return dev; } diff --git a/include/media/rc-core.h b/include/media/rc-core.h index b6586a9..c6bf1ef 100644 --- a/include/media/rc-core.h +++ b/include/media/rc-core.h @@ -185,7 +185,7 @@ struct rc_dev { * Remote Controller, at sys/class/rc. */ -struct rc_dev *rc_allocate_device(void); +struct rc_dev *rc_allocate_device(enum rc_driver_type); void rc_free_device(struct rc_dev *dev); int rc_register_device(struct rc_dev *dev); void rc_unregister_device(struct rc_dev *dev);
The driver type can be assigned immediately when an RC device requests to the framework to allocate the device. This is an 'enum rc_driver_type' data type and specifies whether the device is a raw receiver or scancode receiver. The type will be given as parameter to the rc_allocate_device device. Suggested-by: Sean Young <sean@mess.org> Signed-off-by: Andi Shyti <andi.shyti@samsung.com> --- drivers/media/rc/rc-main.c | 4 +++- include/media/rc-core.h | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-)