| Message ID | 1469519027-11387-2-git-send-email-quentin.schulz@free-electrons.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hello, On Tue, 26 Jul 2016 09:43:44 +0200, Quentin Schulz wrote: > -module_platform_driver(iio_hwmon_driver); > +static struct platform_driver * const drivers[] = { > + &iio_hwmon_driver, > +}; > + > +static int __init iio_hwmon_late_init(void) > +{ > + return platform_register_drivers(drivers, ARRAY_SIZE(drivers)); Why not platform_register_driver() ? This would avoid the need to declare an array with just one entry. Thomas
Hi, On 26/07/2016 09:48, Thomas Petazzoni wrote: > Hello, > > On Tue, 26 Jul 2016 09:43:44 +0200, Quentin Schulz wrote: > >> -module_platform_driver(iio_hwmon_driver); >> +static struct platform_driver * const drivers[] = { >> + &iio_hwmon_driver, >> +}; >> + >> +static int __init iio_hwmon_late_init(void) >> +{ >> + return platform_register_drivers(drivers, ARRAY_SIZE(drivers)); > > Why not platform_register_driver() ? > > This would avoid the need to declare an array with just one entry. Actually, it is named platform_driver_register() as you just showed me and that's the reason I didn't find it under platform_register_driver(). Thanks! Quentin
On Tuesday 26 July 2016 09:43:44, Quentin Schulz wrote: > iio_channel_get_all returns -ENODEV when it cannot find either phandles and > properties in the Device Tree or channels whose consumer_dev_name matches > iio_hwmon in iio_map_list. The iio_map_list is filled in by iio drivers > which might be probed after iio_hwmon. Would it work if iio_channel_get_all returning ENODEV is used for returning EPROBE_DEFER in iio_channel_get_all? Using late initcalls for driver/device dependencies seems not right for me at this place. Best regards, Alexander
On 26/07/2016 10:21, Alexander Stein wrote: > On Tuesday 26 July 2016 09:43:44, Quentin Schulz wrote: >> iio_channel_get_all returns -ENODEV when it cannot find either phandles and >> properties in the Device Tree or channels whose consumer_dev_name matches >> iio_hwmon in iio_map_list. The iio_map_list is filled in by iio drivers >> which might be probed after iio_hwmon. > > Would it work if iio_channel_get_all returning ENODEV is used for returning > EPROBE_DEFER in iio_channel_get_all? Using late initcalls for driver/device > dependencies seems not right for me at this place. Then what if the iio_channel_get_all is called outside of the probe of a driver? We'll have to change the error code, things we are apparently trying to avoid (see v2 patches' discussions). Thanks, Quentin
diff --git a/drivers/hwmon/iio_hwmon.c b/drivers/hwmon/iio_hwmon.c index b550ba5..0a00bfb 100644 --- a/drivers/hwmon/iio_hwmon.c +++ b/drivers/hwmon/iio_hwmon.c @@ -192,7 +192,21 @@ static struct platform_driver __refdata iio_hwmon_driver = { .remove = iio_hwmon_remove, }; -module_platform_driver(iio_hwmon_driver); +static struct platform_driver * const drivers[] = { + &iio_hwmon_driver, +}; + +static int __init iio_hwmon_late_init(void) +{ + return platform_register_drivers(drivers, ARRAY_SIZE(drivers)); +} +late_initcall(iio_hwmon_late_init); + +static void __exit iio_hwmon_exit(void) +{ + platform_unregister_drivers(drivers, ARRAY_SIZE(drivers)); +} +module_exit(iio_hwmon_exit); MODULE_AUTHOR("Jonathan Cameron <jic23@kernel.org>"); MODULE_DESCRIPTION("IIO to hwmon driver");
iio_channel_get_all returns -ENODEV when it cannot find either phandles and properties in the Device Tree or channels whose consumer_dev_name matches iio_hwmon in iio_map_list. The iio_map_list is filled in by iio drivers which might be probed after iio_hwmon. This makes sure iio_hwmon is probed after all iio drivers which provides channels to iio_hwmon are probed, be they present in the DT or using iio_map_list. This replaces module_platform_driver() by an explicit code variant which calls late_initcall() install of module_init(), meaning it probes after all the drivers using module_init() as their init. Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com> --- v3: - use late_initcall instead of deferring probe, drivers/hwmon/iio_hwmon.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-)