| Message ID | 1469832982-21390-1-git-send-email-jfehlig@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Jim Fehlig writes ("[PATCH] docs: define semantics of vncpasswd in xl.cfg"):
> A recent discussion around LSN-2016-0001 [1] included defining
> the sematics of an empty string for a VNC password. It was stated
> that "libxl interprets an empty password in the caller's
> configuration to mean that passwordless access should be permitted".
>
> The same applies for vncpasswd setting in xl.cfg. This patch
> extends to xl.cfg documentation to define the semantics of setting
> vncpasswd to an empty string.
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
I think this is a backport candidate.
Ian.
On Mon, Aug 01, 2016 at 10:44:45AM +0100, Ian Jackson wrote: > Jim Fehlig writes ("[PATCH] docs: define semantics of vncpasswd in xl.cfg"): > > A recent discussion around LSN-2016-0001 [1] included defining > > the sematics of an empty string for a VNC password. It was stated > > that "libxl interprets an empty password in the caller's > > configuration to mean that passwordless access should be permitted". > > > > The same applies for vncpasswd setting in xl.cfg. This patch > > extends to xl.cfg documentation to define the semantics of setting > > vncpasswd to an empty string. > > Acked-by: Ian Jackson <ian.jackson@eu.citrix.com> > > I think this is a backport candidate. > Acked + pushed. > Ian.
diff --git a/docs/man/xl.cfg.pod.5.in b/docs/man/xl.cfg.pod.5.in index 3bb27d0..48c9c0d 100644 --- a/docs/man/xl.cfg.pod.5.in +++ b/docs/man/xl.cfg.pod.5.in @@ -561,7 +561,9 @@ The actual display used can be accessed with C<xl vncviewer>. =item C<vncpasswd="PASSWORD"> -Specifies the password for the VNC server. +Specifies the password for the VNC server. If password is set to an +empty string, authentication on the VNC server will be disabled +allowing any user to connect. =item C<sdl=BOOLEAN> @@ -1689,7 +1691,9 @@ The actual display used can be accessed with C<xl vncviewer>. =item B<vncpasswd="PASSWORD"> -Specifies the password for the VNC server. +Specifies the password for the VNC server. If password is set to an +empty string, authentication on the VNC server will be disabled +allowing any user to connect. =item B<keymap="LANG">
A recent discussion around LSN-2016-0001 [1] included defining the sematics of an empty string for a VNC password. It was stated that "libxl interprets an empty password in the caller's configuration to mean that passwordless access should be permitted". The same applies for vncpasswd setting in xl.cfg. This patch extends to xl.cfg documentation to define the semantics of setting vncpasswd to an empty string. Signed-off-by: Jim Fehlig <jfehlig@suse.com> --- docs/man/xl.cfg.pod.5.in | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)