| Message ID | 20160802143752.12831-2-aar@pengutronix.de (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
Hi Alex, On Tue, Aug 2, 2016 at 5:37 PM, Alexander Aring <aar@pengutronix.de> wrote: > This patch changes the ARPHRD_IEEE802154 to ARPHRD_6LOWPAN. The IEEE > 802.15.4 6lowpan module changed the ARPHRD_IEEE802154 type to > ARPHRD_6LOWPAN. Nowadays it's use ARPHRD_6LOWPAN which is also used by > BTLE 6LoWPAN. Both interfaces uses an EUI64 address and the handling to > get the link-layer address should be the same. Bluetooth MAC addresses are 48 bits long, it could be converted to 64 bits to generate the so called IID but that is only to generate the link-local address: https://tools.ietf.org/html/rfc7668#section-3.2.2 > There is no backward compatibility for 802.15.4 6LoWPAN before we > changed the ARPHRD. Anyway if somebody wants that it should be patched > manually. When the ARPHRD was ARPHRD_IEEE802154 the 802.15.4 6lowpan was > anyway in a somehow unusable state. > > Signed-off-by: Alexander Aring <aar@pengutronix.de> > --- > device-linux.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/device-linux.c b/device-linux.c > index de83f2e..7301927 100644 > --- a/device-linux.c > +++ b/device-linux.c > @@ -22,6 +22,10 @@ > #define IPV6_ADDR_LINKLOCAL 0x0020U > #endif > > +#ifndef ARPHRD_6LOWPAN > +#define ARPHRD_6LOWPAN 825 /* IPv6 over LoWPAN */ > +#endif > + > static char const *hwstr(unsigned short sa_family); > > /* > @@ -79,12 +83,10 @@ int update_device_info(int sock, struct Interface *iface) > iface->sllao.if_maxmtu = -1; > break; > #endif /* ARPHDR_ARCNET */ > -#ifdef ARPHRD_IEEE802154 > - case ARPHRD_IEEE802154: > + case ARPHRD_6LOWPAN: > iface->sllao.if_hwaddr_len = 64; > iface->sllao.if_prefix_len = 64; > break; > -#endif > default: > iface->sllao.if_hwaddr_len = -1; > iface->sllao.if_prefix_len = -1; > @@ -382,6 +384,9 @@ static char const *hwstr(unsigned short sa_family) > rc = "ARPHRD_IEEE802154_PHY"; > break; > #endif > + case ARPHRD_6LOWPAN: > + rc = "ARPHRD_6LOWPAN"; > + break; > case ARPHRD_VOID: > rc = "ARPHRD_VOID"; > break; > -- > 2.9.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On 08/04/2016 10:26 AM, Luiz Augusto von Dentz wrote: > Hi Alex, > > On Tue, Aug 2, 2016 at 5:37 PM, Alexander Aring <aar@pengutronix.de> wrote: >> This patch changes the ARPHRD_IEEE802154 to ARPHRD_6LOWPAN. The IEEE >> 802.15.4 6lowpan module changed the ARPHRD_IEEE802154 type to >> ARPHRD_6LOWPAN. Nowadays it's use ARPHRD_6LOWPAN which is also used by >> BTLE 6LoWPAN. Both interfaces uses an EUI64 address and the handling to >> get the link-layer address should be the same. > > Bluetooth MAC addresses are 48 bits long, it could be converted to 64 > bits to generate the so called IID but that is only to generate the > link-local address: > > https://tools.ietf.org/html/rfc7668#section-3.2.2 > Ah, yes sorry. This commit msg was created in a time when I just looked into the bluetooth code ans saw dev->addr_len = 8 and trust it. :-) Patch 2/2 will care about different address lengths. btw: Radvd needs the device address for option: AdvSourceLLAddress on|off see [0]. However Patch 2/2 will fix it, I just need to convert to a netlink handling. I have it running now, but it looks ugly (maybe that's normal when doing low-level netlink stuff). I will fix the commit msg. - Alex [0] http://linux.die.net/man/5/radvd.conf -- To unsubscribe from this list: send the line "unsubscribe linux-wpan" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/device-linux.c b/device-linux.c index de83f2e..7301927 100644 --- a/device-linux.c +++ b/device-linux.c @@ -22,6 +22,10 @@ #define IPV6_ADDR_LINKLOCAL 0x0020U #endif +#ifndef ARPHRD_6LOWPAN +#define ARPHRD_6LOWPAN 825 /* IPv6 over LoWPAN */ +#endif + static char const *hwstr(unsigned short sa_family); /* @@ -79,12 +83,10 @@ int update_device_info(int sock, struct Interface *iface) iface->sllao.if_maxmtu = -1; break; #endif /* ARPHDR_ARCNET */ -#ifdef ARPHRD_IEEE802154 - case ARPHRD_IEEE802154: + case ARPHRD_6LOWPAN: iface->sllao.if_hwaddr_len = 64; iface->sllao.if_prefix_len = 64; break; -#endif default: iface->sllao.if_hwaddr_len = -1; iface->sllao.if_prefix_len = -1; @@ -382,6 +384,9 @@ static char const *hwstr(unsigned short sa_family) rc = "ARPHRD_IEEE802154_PHY"; break; #endif + case ARPHRD_6LOWPAN: + rc = "ARPHRD_6LOWPAN"; + break; case ARPHRD_VOID: rc = "ARPHRD_VOID"; break;
This patch changes the ARPHRD_IEEE802154 to ARPHRD_6LOWPAN. The IEEE 802.15.4 6lowpan module changed the ARPHRD_IEEE802154 type to ARPHRD_6LOWPAN. Nowadays it's use ARPHRD_6LOWPAN which is also used by BTLE 6LoWPAN. Both interfaces uses an EUI64 address and the handling to get the link-layer address should be the same. There is no backward compatibility for 802.15.4 6LoWPAN before we changed the ARPHRD. Anyway if somebody wants that it should be patched manually. When the ARPHRD was ARPHRD_IEEE802154 the 802.15.4 6lowpan was anyway in a somehow unusable state. Signed-off-by: Alexander Aring <aar@pengutronix.de> --- device-linux.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-)