diff mbox

[xfsprogs,13/14] xfs.h: require transparent LFS

Message ID 3be2b10b0037406374a415fda2318cbf95a67546.1470555003.git.felix.janda@posteo.de (mailing list archive)
State Superseded, archived
Headers show

Commit Message

Felix Janda Aug. 7, 2016, 5:43 a.m. UTC 
Since our interfaces depend on the consistent use of a 64bit offset
type, we force downstreams to use transparent LFS
(_FILE_OFFSET_BITS=64), so that it becomes impossible for them to use
32bit interfaces.

Signed-off-by: Felix Janda <felix.janda@posteo.de>
---
 include/xfs.h | 2 ++
 1 file changed, 2 insertions(+)

Comments

Christoph Hellwig Aug. 9, 2016, 7:41 a.m. UTC | #1 
> +extern int xfs_assert_largefile[sizeof(off_t)-8];

Please add a comment on why we have this declaration, otherwise this
looks fine to me:

Reviewed-by: Christoph Hellwig <hch@lst.de>
diff mbox

Patch

diff --git a/include/xfs.h b/include/xfs.h
index 7bed957..37c95fe 100644
--- a/include/xfs.h
+++ b/include/xfs.h
@@ -47,6 +47,8 @@ 
 # error unknown platform... have fun porting!
 #endif
 
+extern int xfs_assert_largefile[sizeof(off_t)-8];
+
 /*
  * sparse kernel source annotations
  */