| Message ID | 1471256227-6282-1-git-send-email-strongbox8@zoho.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
Hi, 2016-08-15 19:17 GMT+09:00 perr <strongbox8@zoho.com>: > Because chained_irq_enter() has already called chip->irq_mask() and > chip->irq_ack(), also chained_irq_exit() will call chip->irq_unmask(), > so it's not necessary to call chip->irq_*() here. > > Signed-off-by: perr <strongbox8@zoho.com> > > --- > drivers/pinctrl/samsung/pinctrl-exynos.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > Indeed, nice finding. Thanks! Acked-by: Tomasz Figa <tomasz.figa@gmail.com> Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Aug 15, 2016 at 06:17:07PM +0800, perr wrote: > Because chained_irq_enter() has already called chip->irq_mask() and > chip->irq_ack(), also chained_irq_exit() will call chip->irq_unmask(), > so it's not necessary to call chip->irq_*() here. > > Signed-off-by: perr <strongbox8@zoho.com> > > --- > drivers/pinctrl/samsung/pinctrl-exynos.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > Looks correct so for the patch itself: Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> However, your name "Perr" confuses me a little bit. For the Signed-off-by statement, as mentioned in Documentation/SubmittingPatches, a real name is required. The name should match the author. Would you be so kind as to use a full, real name? Unless Perr is your full, real name... then sorry for the trouble. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Sent using Zoho Mail ---- On Mon, 15 Aug 2016 09:59:41 -0700 Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote ---- > On Mon, Aug 15, 2016 at 06:17:07PM +0800, perr wrote: > > Because chained_irq_enter() has already called chip->irq_mask() and > > chip->irq_ack(), also chained_irq_exit() will call chip->irq_unmask(), > > so it's not necessary to call chip->irq_*() here. > > > > Signed-off-by: perr <strongbox8@zoho.com> > > > > --- > > drivers/pinctrl/samsung/pinctrl-exynos.c | 6 +----- > > 1 file changed, 1 insertion(+), 5 deletions(-) > > > > > Looks correct so for the patch itself: > Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > > However, your name "Perr" confuses me a little bit. For the > Signed-off-by statement, as mentioned in > Documentation/SubmittingPatches, a real name is required. The name > should match the author. > > Would you be so kind as to use a full, real name? Unless Perr is your > full, real name... then sorry for the trouble. Perr Zhang <strongbox8@zoho.com> is OK? I'm from China. Perr is my first name in English. > > Best regards, > Krzysztof > > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 08/16/2016 01:58 AM, perr perr wrote: > ---- On Mon, 15 Aug 2016 09:59:41 -0700 Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote ---- > > On Mon, Aug 15, 2016 at 06:17:07PM +0800, perr wrote: > > > Because chained_irq_enter() has already called chip->irq_mask() and > > > chip->irq_ack(), also chained_irq_exit() will call chip->irq_unmask(), > > > so it's not necessary to call chip->irq_*() here. > > > > > > Signed-off-by: perr <strongbox8@zoho.com> > > > > > > --- > > > drivers/pinctrl/samsung/pinctrl-exynos.c | 6 +----- > > > 1 file changed, 1 insertion(+), 5 deletions(-) > > > > > > > > > Looks correct so for the patch itself: > > Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > > > > However, your name "Perr" confuses me a little bit. For the > > Signed-off-by statement, as mentioned in > > Documentation/SubmittingPatches, a real name is required. The name > > should match the author. > > > > Would you be so kind as to use a full, real name? Unless Perr is your > > full, real name... then sorry for the trouble. > Perr Zhang <strongbox8@zoho.com> is OK? > I'm from China. Perr is my first name in English. Yes, seems fine. Could you resend with updated name? Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pinctrl/samsung/pinctrl-exynos.c b/drivers/pinctrl/samsung/pinctrl-exynos.c index 051b5bf..d32fa2b 100644 --- a/drivers/pinctrl/samsung/pinctrl-exynos.c +++ b/drivers/pinctrl/samsung/pinctrl-exynos.c @@ -428,14 +428,10 @@ static void exynos_irq_eint0_15(struct irq_desc *desc) int eint_irq; chained_irq_enter(chip, desc); - chip->irq_mask(&desc->irq_data); - - if (chip->irq_ack) - chip->irq_ack(&desc->irq_data); eint_irq = irq_linear_revmap(bank->irq_domain, eintd->irq); generic_handle_irq(eint_irq); - chip->irq_unmask(&desc->irq_data); + chained_irq_exit(chip, desc); }
Because chained_irq_enter() has already called chip->irq_mask() and chip->irq_ack(), also chained_irq_exit() will call chip->irq_unmask(), so it's not necessary to call chip->irq_*() here. Signed-off-by: perr <strongbox8@zoho.com> --- drivers/pinctrl/samsung/pinctrl-exynos.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)