| Message ID | 1471316363-19378-1-git-send-email-yamada.masahiro@socionext.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Tue, Aug 16, 2016 at 11:59:23AM +0900, Masahiro Yamada wrote: > Commit fe6b0dfaba68 ("Input: tegra-kbc - use reset framework") > accidentally converted _deassert to _assert, so there is no code > to wake up this hardware. > > Fixes: fe6b0dfaba68 ("Input: tegra-kbc - use reset framework") > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > > drivers/input/keyboard/tegra-kbc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Nice catch! Acked-by: Thierry Reding <treding@nvidia.com>
On Tuesday 16 August 2016 08:29 AM, Masahiro Yamada wrote: > Commit fe6b0dfaba68 ("Input: tegra-kbc - use reset framework") > accidentally converted _deassert to _assert, so there is no code > to wake up this hardware. > > Fixes: fe6b0dfaba68 ("Input: tegra-kbc - use reset framework") > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > Acked-by: Laxman Dewangan <ldewangan@nvidia.com> -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Aug 16, 2016 at 11:59:23AM +0900, Masahiro Yamada wrote: > Commit fe6b0dfaba68 ("Input: tegra-kbc - use reset framework") > accidentally converted _deassert to _assert, so there is no code > to wake up this hardware. > > Fixes: fe6b0dfaba68 ("Input: tegra-kbc - use reset framework") > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Applied, thank you. > --- > > drivers/input/keyboard/tegra-kbc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/keyboard/tegra-kbc.c b/drivers/input/keyboard/tegra-kbc.c > index 7d61439..0c07e10 100644 > --- a/drivers/input/keyboard/tegra-kbc.c > +++ b/drivers/input/keyboard/tegra-kbc.c > @@ -376,7 +376,7 @@ static int tegra_kbc_start(struct tegra_kbc *kbc) > /* Reset the KBC controller to clear all previous status.*/ > reset_control_assert(kbc->rst); > udelay(100); > - reset_control_assert(kbc->rst); > + reset_control_deassert(kbc->rst); > udelay(100); > > tegra_kbc_config_pins(kbc); > -- > 1.9.1 >
diff --git a/drivers/input/keyboard/tegra-kbc.c b/drivers/input/keyboard/tegra-kbc.c index 7d61439..0c07e10 100644 --- a/drivers/input/keyboard/tegra-kbc.c +++ b/drivers/input/keyboard/tegra-kbc.c @@ -376,7 +376,7 @@ static int tegra_kbc_start(struct tegra_kbc *kbc) /* Reset the KBC controller to clear all previous status.*/ reset_control_assert(kbc->rst); udelay(100); - reset_control_assert(kbc->rst); + reset_control_deassert(kbc->rst); udelay(100); tegra_kbc_config_pins(kbc);
Commit fe6b0dfaba68 ("Input: tegra-kbc - use reset framework") accidentally converted _deassert to _assert, so there is no code to wake up this hardware. Fixes: fe6b0dfaba68 ("Input: tegra-kbc - use reset framework") Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- drivers/input/keyboard/tegra-kbc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)