| Message ID | 1471419298-10414-1-git-send-email-k.kozlowski@samsung.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Wed, Aug 17, 2016 at 09:34:58AM +0200, Krzysztof Kozlowski wrote: > The "linux,stdout-path" is deprecated. > > Add serial options so the console can be properly configured when > bootloader does not pass "console" parameter to command line. Without > options and lack of "console", the serial output dies during boot (just > after probing sound). I'm confused. Is this just a cleanup (given "linux,stdout-path" is deprecated but still supported), or a bug fix? I guess that prior to this patch Linux might change the rate of the console, but otherwise it should work. Mark. > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > --- > arch/arm/boot/dts/exynos5410-odroidxu.dts | 2 +- > arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos5410-odroidxu.dts b/arch/arm/boot/dts/exynos5410-odroidxu.dts > index f6d135245a4b..a5ae76c1838f 100644 > --- a/arch/arm/boot/dts/exynos5410-odroidxu.dts > +++ b/arch/arm/boot/dts/exynos5410-odroidxu.dts > @@ -26,7 +26,7 @@ > }; > > chosen { > - linux,stdout-path = &serial_2; > + stdout-path = "serial2:115200n8"; > }; > > emmc_pwrseq: pwrseq { > diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > index d56253049ccb..d04490d40b07 100644 > --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > @@ -26,7 +26,7 @@ > }; > > chosen { > - linux,stdout-path = &serial_2; > + stdout-path = "serial2:115200n8"; > }; > > firmware@02073000 { > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 08/17/2016 12:25 PM, Mark Rutland wrote: > On Wed, Aug 17, 2016 at 09:34:58AM +0200, Krzysztof Kozlowski wrote: >> The "linux,stdout-path" is deprecated. >> >> Add serial options so the console can be properly configured when >> bootloader does not pass "console" parameter to command line. Without >> options and lack of "console", the serial output dies during boot (just >> after probing sound). > > I'm confused. Is this just a cleanup (given "linux,stdout-path" is > deprecated but still supported), or a bug fix? There is no bug, so rather this is cleanup and improvement in one. Usually we pass full console=ttySAC2,115200n8 from UBoot to command line. The usage of serial options allows skipping that. I can split the cleanup part from improvement. To me it looked a little bit too much but I don't mind. > I guess that prior to this patch Linux might change the rate of the > console, but otherwise it should work. It still can be overridden by command line if needed. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Aug 17, 2016 at 12:28:48PM +0200, Krzysztof Kozlowski wrote: > On 08/17/2016 12:25 PM, Mark Rutland wrote: > > On Wed, Aug 17, 2016 at 09:34:58AM +0200, Krzysztof Kozlowski wrote: > >> The "linux,stdout-path" is deprecated. > >> > >> Add serial options so the console can be properly configured when > >> bootloader does not pass "console" parameter to command line. Without > >> options and lack of "console", the serial output dies during boot (just > >> after probing sound). > > > > I'm confused. Is this just a cleanup (given "linux,stdout-path" is > > deprecated but still supported), or a bug fix? > > There is no bug, so rather this is cleanup and improvement in one. > Usually we pass full console=ttySAC2,115200n8 from UBoot to command > line. The usage of serial options allows skipping that. > > I can split the cleanup part from improvement. To me it looked a little > bit too much but I don't mind. No need. It just wasn't clear to me that you had U-Boot configured to pass the rate on the command line. As I mentioned, I suspect that the serial output doesn't "die" as such, but rather changes rate. It might be worth clarifying that in the commit message, but either way the patch itself is fine, and it's no big deal. Thanks, Mark. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello Krzysztof, On 08/17/2016 03:34 AM, Krzysztof Kozlowski wrote: > The "linux,stdout-path" is deprecated. > > Add serial options so the console can be properly configured when > bootloader does not pass "console" parameter to command line. Without > options and lack of "console", the serial output dies during boot (just > after probing sound). > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > --- The patch looks good to me. Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> Best regards,
diff --git a/arch/arm/boot/dts/exynos5410-odroidxu.dts b/arch/arm/boot/dts/exynos5410-odroidxu.dts index f6d135245a4b..a5ae76c1838f 100644 --- a/arch/arm/boot/dts/exynos5410-odroidxu.dts +++ b/arch/arm/boot/dts/exynos5410-odroidxu.dts @@ -26,7 +26,7 @@ }; chosen { - linux,stdout-path = &serial_2; + stdout-path = "serial2:115200n8"; }; emmc_pwrseq: pwrseq { diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi index d56253049ccb..d04490d40b07 100644 --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi @@ -26,7 +26,7 @@ }; chosen { - linux,stdout-path = &serial_2; + stdout-path = "serial2:115200n8"; }; firmware@02073000 {
The "linux,stdout-path" is deprecated. Add serial options so the console can be properly configured when bootloader does not pass "console" parameter to command line. Without options and lack of "console", the serial output dies during boot (just after probing sound). Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> --- arch/arm/boot/dts/exynos5410-odroidxu.dts | 2 +- arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)