| Message ID | 1471511444-44780-1-git-send-email-roger.pau@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 18/08/16 10:10, Roger Pau Monne wrote: > This is a side-effect of commit c36e1c, which currently prevents compiling > xenalyze with libcs that don't have argp built-in. > > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> I don't have the expertise to know if this is the Right Way to solve this problem; but regarding the principle: Acked-by: George Dunlap <george.dunlap@citrix.com> > --- > Cc: George Dunlap <george.dunlap@citrix.com> > Cc: Wei Liu <wei.liu2@citrix.com> > Cc: Ian Jackson <ian.jackson@eu.citrix.com> > --- > tools/xentrace/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/xentrace/Makefile b/tools/xentrace/Makefile > index a85ed33..c8c36a8 100644 > --- a/tools/xentrace/Makefile > +++ b/tools/xentrace/Makefile > @@ -50,7 +50,7 @@ xentrace_setsize: setsize.o > $(CC) $(LDFLAGS) -o $@ $< $(LDLIBS) $(APPEND_LDFLAGS) > > xenalyze: xenalyze.o mread.o > - $(CC) $(LDFLAGS) -o $@ $^ $(APPEND_LDFLAGS) > + $(CC) $(LDFLAGS) -o $@ $^ $(ARGP_LDFLAGS) $(APPEND_LDFLAGS) > > -include $(DEPS) > >
On Thu, Aug 18, 2016 at 11:10:44AM +0200, Roger Pau Monne wrote: > This is a side-effect of commit c36e1c, which currently prevents compiling > xenalyze with libcs that don't have argp built-in. > > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> Acked-by: Wei Liu <wei.liu2@citrix.com> > --- > Cc: George Dunlap <george.dunlap@citrix.com> > Cc: Wei Liu <wei.liu2@citrix.com> > Cc: Ian Jackson <ian.jackson@eu.citrix.com> > --- > tools/xentrace/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/xentrace/Makefile b/tools/xentrace/Makefile > index a85ed33..c8c36a8 100644 > --- a/tools/xentrace/Makefile > +++ b/tools/xentrace/Makefile > @@ -50,7 +50,7 @@ xentrace_setsize: setsize.o > $(CC) $(LDFLAGS) -o $@ $< $(LDLIBS) $(APPEND_LDFLAGS) > > xenalyze: xenalyze.o mread.o > - $(CC) $(LDFLAGS) -o $@ $^ $(APPEND_LDFLAGS) > + $(CC) $(LDFLAGS) -o $@ $^ $(ARGP_LDFLAGS) $(APPEND_LDFLAGS) > > -include $(DEPS) > > -- > 2.7.4 (Apple Git-66) >
Queued.
diff --git a/tools/xentrace/Makefile b/tools/xentrace/Makefile index a85ed33..c8c36a8 100644 --- a/tools/xentrace/Makefile +++ b/tools/xentrace/Makefile @@ -50,7 +50,7 @@ xentrace_setsize: setsize.o $(CC) $(LDFLAGS) -o $@ $< $(LDLIBS) $(APPEND_LDFLAGS) xenalyze: xenalyze.o mread.o - $(CC) $(LDFLAGS) -o $@ $^ $(APPEND_LDFLAGS) + $(CC) $(LDFLAGS) -o $@ $^ $(ARGP_LDFLAGS) $(APPEND_LDFLAGS) -include $(DEPS)
This is a side-effect of commit c36e1c, which currently prevents compiling xenalyze with libcs that don't have argp built-in. Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> --- Cc: George Dunlap <george.dunlap@citrix.com> Cc: Wei Liu <wei.liu2@citrix.com> Cc: Ian Jackson <ian.jackson@eu.citrix.com> --- tools/xentrace/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)