diff mbox

[2/4] arm64: defconfig: Set cma heap size to 128MB

Message ID 1471621328-21102-3-git-send-email-guodong.xu@linaro.org (mailing list archive)
State New, archived
Headers show

Commit Message

Guodong Xu Aug. 19, 2016, 3:42 p.m. UTC 
From: Xinliang Liu <xinliang.liu@linaro.org>

For debian linux, cma heap is used to allocate graphic buffers.
The default size is 16 MB which is not enought.
So increase the size to 128 MB.

Signed-off-by: Xinliang Liu <xinliang.liu@linaro.org>
---
 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Thierry Reding Aug. 22, 2016, 9:06 a.m. UTC | #1 
On Fri, Aug 19, 2016 at 11:42:06PM +0800, Guodong Xu wrote:
> From: Xinliang Liu <xinliang.liu@linaro.org>
> 
> For debian linux, cma heap is used to allocate graphic buffers.
> The default size is 16 MB which is not enought.
> So increase the size to 128 MB.
> 
> Signed-off-by: Xinliang Liu <xinliang.liu@linaro.org>
> ---
>  arch/arm64/configs/defconfig | 1 +
>  1 file changed, 1 insertion(+)

This is a bad idea. You're increasing this heap for all users of the
default configuration (which on 64-bit ARM is everyone, really). Many of
the devices don't require the CMA except maybe for the occasional very
small buffer. Most implement some form of IOMMU support that removes the
need for large amounts of contiguous physical memory.

I think it's a better idea to have some bootloader append a cma=128 to
the kernel command-line if necessary.

Thierry
Guodong Xu Aug. 24, 2016, 2:23 a.m. UTC | #2 
On 22 August 2016 at 17:06, Thierry Reding <treding@nvidia.com> wrote:
> On Fri, Aug 19, 2016 at 11:42:06PM +0800, Guodong Xu wrote:
>> From: Xinliang Liu <xinliang.liu@linaro.org>
>>
>> For debian linux, cma heap is used to allocate graphic buffers.
>> The default size is 16 MB which is not enought.
>> So increase the size to 128 MB.
>>
>> Signed-off-by: Xinliang Liu <xinliang.liu@linaro.org>
>> ---
>>  arch/arm64/configs/defconfig | 1 +
>>  1 file changed, 1 insertion(+)
>
> This is a bad idea. You're increasing this heap for all users of the
> default configuration (which on 64-bit ARM is everyone, really). Many of
> the devices don't require the CMA except maybe for the occasional very
> small buffer. Most implement some form of IOMMU support that removes the
> need for large amounts of contiguous physical memory.
>
> I think it's a better idea to have some bootloader append a cma=128 to
> the kernel command-line if necessary.
>

I will remove this. Thanks.

-Guodong Xu

> Thierry
diff mbox

Patch

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index e27f086..c94f2fa 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -130,6 +130,7 @@  CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug"
 CONFIG_DEVTMPFS=y
 CONFIG_DEVTMPFS_MOUNT=y
 CONFIG_DMA_CMA=y
+CONFIG_CMA_SIZE_MBYTES=128
 CONFIG_MTD=y
 CONFIG_MTD_M25P80=y
 CONFIG_MTD_SPI_NOR=y