| Message ID | 1471834603-27053-3-git-send-email-xieyisheng1@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon 22-08-16 10:56:43, Xie Yisheng wrote: > Arm64 supports gigantic page after > commit 084bd29810a5 ("ARM64: mm: HugeTLB support.") > however, it got broken by > commit 944d9fec8d7a ("hugetlb: add support for gigantic page > allocation at runtime") > > This patch selects ARCH_HAS_GIGANTIC_PAGE to make this > function can be used again. I haven't double checked that the above commit really broke it but if that is the case then Fixes: 944d9fec8d7a ("hugetlb: add support for gigantic page allocation at runtime") would be nice as well I guess. I do not think that marking it for stable is really necessary considering how long it's been broken and nobody has noticed... > Signed-off-by: Xie Yisheng <xieyisheng1@huawei.com> Acked-by: Michal Hocko <mhocko@suse.com> > --- > arch/arm64/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index bc3f00f..92217f6 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -9,6 +9,7 @@ config ARM64 > select ARCH_HAS_ATOMIC64_DEC_IF_POSITIVE > select ARCH_HAS_ELF_RANDOMIZE > select ARCH_HAS_GCOV_PROFILE_ALL > + select ARCH_HAS_GIGANTIC_PAGE > select ARCH_HAS_KCOV > select ARCH_HAS_SG_CHAIN > select ARCH_HAS_TICK_BROADCAST if GENERIC_CLOCKEVENTS_BROADCAST > -- > 1.7.12.4 >
On Mon, Aug 22, 2016 at 10:03:58AM +0200, Michal Hocko wrote: > On Mon 22-08-16 10:56:43, Xie Yisheng wrote: > > Arm64 supports gigantic page after > > commit 084bd29810a5 ("ARM64: mm: HugeTLB support.") > > however, it got broken by > > commit 944d9fec8d7a ("hugetlb: add support for gigantic page > > allocation at runtime") > > > > This patch selects ARCH_HAS_GIGANTIC_PAGE to make this > > function can be used again. > > I haven't double checked that the above commit really broke it but if > that is the case then > > Fixes: 944d9fec8d7a ("hugetlb: add support for gigantic page allocation at runtime") > > would be nice as well I guess. I do not think that marking it for stable > is really necessary considering how long it's been broken and nobody has > noticed... I'm not sure that commit broke it. The gigantic functionality introduced by the above commit was under an #ifdef CONFIG_X86_64. Prior to that we had a VM_BUG_ON(hstate_is_gigantic(h)).
On Mon, Aug 22, 2016 at 10:56:43AM +0800, Xie Yisheng wrote: > Arm64 supports gigantic page after > commit 084bd29810a5 ("ARM64: mm: HugeTLB support.") > however, it got broken by > commit 944d9fec8d7a ("hugetlb: add support for gigantic page > allocation at runtime") > > This patch selects ARCH_HAS_GIGANTIC_PAGE to make this > function can be used again. > > Signed-off-by: Xie Yisheng <xieyisheng1@huawei.com> > --- > arch/arm64/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index bc3f00f..92217f6 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -9,6 +9,7 @@ config ARM64 > select ARCH_HAS_ATOMIC64_DEC_IF_POSITIVE > select ARCH_HAS_ELF_RANDOMIZE > select ARCH_HAS_GCOV_PROFILE_ALL > + select ARCH_HAS_GIGANTIC_PAGE Acked-by: Catalin Marinas <catalin.marinas@arm.com>
On 2016/8/22 18:00, Catalin Marinas wrote: > On Mon, Aug 22, 2016 at 10:03:58AM +0200, Michal Hocko wrote: >> On Mon 22-08-16 10:56:43, Xie Yisheng wrote: >>> Arm64 supports gigantic page after >>> commit 084bd29810a5 ("ARM64: mm: HugeTLB support.") >>> however, it got broken by >>> commit 944d9fec8d7a ("hugetlb: add support for gigantic page >>> allocation at runtime") >>> >>> This patch selects ARCH_HAS_GIGANTIC_PAGE to make this >>> function can be used again. >> >> I haven't double checked that the above commit really broke it but if >> that is the case then >> >> Fixes: 944d9fec8d7a ("hugetlb: add support for gigantic page allocation at runtime") >> >> would be nice as well I guess. I do not think that marking it for stable >> is really necessary considering how long it's been broken and nobody has >> noticed... > > I'm not sure that commit broke it. The gigantic functionality introduced > by the above commit was under an #ifdef CONFIG_X86_64. Prior > to that we had a VM_BUG_ON(hstate_is_gigantic(h)). > Hi Catalin and Michal , Thank you for your reply. Before that commit gigantic pages can only be allocated at boottime and can't be freed. That why we had VM_BUG_ON(hstate_is_gigantic(h)) in function update_and_free_page() Prior to that. Anyway, it should not just add #ifdef CONFIG_X86_64 for arm64 already supported 1G hugepage before that commit. Right? Please let me know if I miss something. Thanks Xie Yisheng.
diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index bc3f00f..92217f6 100644 --- a/arch/arm64/Kconfig +++ b/arch/arm64/Kconfig @@ -9,6 +9,7 @@ config ARM64 select ARCH_HAS_ATOMIC64_DEC_IF_POSITIVE select ARCH_HAS_ELF_RANDOMIZE select ARCH_HAS_GCOV_PROFILE_ALL + select ARCH_HAS_GIGANTIC_PAGE select ARCH_HAS_KCOV select ARCH_HAS_SG_CHAIN select ARCH_HAS_TICK_BROADCAST if GENERIC_CLOCKEVENTS_BROADCAST
Arm64 supports gigantic page after commit 084bd29810a5 ("ARM64: mm: HugeTLB support.") however, it got broken by commit 944d9fec8d7a ("hugetlb: add support for gigantic page allocation at runtime") This patch selects ARCH_HAS_GIGANTIC_PAGE to make this function can be used again. Signed-off-by: Xie Yisheng <xieyisheng1@huawei.com> --- arch/arm64/Kconfig | 1 + 1 file changed, 1 insertion(+)