diff mbox

mmc: host: vub300: don't print error when allocating urb fails

Message ID 1470949433-24707-2-git-send-email-wsa-dev@sang-engineering.com (mailing list archive)
State New, archived
Headers show

Commit Message

Wolfram Sang Aug. 11, 2016, 9:03 p.m. UTC
kmalloc will print enough information in case of failure.

Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
---
 drivers/mmc/host/vub300.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Ulf Hansson Aug. 22, 2016, 1:39 p.m. UTC | #1
On 11 August 2016 at 23:03, Wolfram Sang <wsa-dev@sang-engineering.com> wrote:
> kmalloc will print enough information in case of failure.
>
> Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>

Thanks, applied for next!

Kind regards
Uffe

> ---
>  drivers/mmc/host/vub300.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mmc/host/vub300.c b/drivers/mmc/host/vub300.c
> index 1e819f98b94f52..bb3e0d1dd35501 100644
> --- a/drivers/mmc/host/vub300.c
> +++ b/drivers/mmc/host/vub300.c
> @@ -2116,13 +2116,11 @@ static int vub300_probe(struct usb_interface *interface,
>         command_out_urb = usb_alloc_urb(0, GFP_KERNEL);
>         if (!command_out_urb) {
>                 retval = -ENOMEM;
> -               dev_err(&udev->dev, "not enough memory for command_out_urb\n");
>                 goto error0;
>         }
>         command_res_urb = usb_alloc_urb(0, GFP_KERNEL);
>         if (!command_res_urb) {
>                 retval = -ENOMEM;
> -               dev_err(&udev->dev, "not enough memory for command_res_urb\n");
>                 goto error1;
>         }
>         /* this also allocates memory for our VUB300 mmc host device */
> --
> 2.8.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/mmc/host/vub300.c b/drivers/mmc/host/vub300.c
index 1e819f98b94f52..bb3e0d1dd35501 100644
--- a/drivers/mmc/host/vub300.c
+++ b/drivers/mmc/host/vub300.c
@@ -2116,13 +2116,11 @@  static int vub300_probe(struct usb_interface *interface,
 	command_out_urb = usb_alloc_urb(0, GFP_KERNEL);
 	if (!command_out_urb) {
 		retval = -ENOMEM;
-		dev_err(&udev->dev, "not enough memory for command_out_urb\n");
 		goto error0;
 	}
 	command_res_urb = usb_alloc_urb(0, GFP_KERNEL);
 	if (!command_res_urb) {
 		retval = -ENOMEM;
-		dev_err(&udev->dev, "not enough memory for command_res_urb\n");
 		goto error1;
 	}
 	/* this also allocates memory for our VUB300 mmc host device */