diff mbox

[-next] net: phy: xgmiitorgmii: Fix non static symbol warning

Message ID 1471964765-32708-1-git-send-email-weiyj.lk@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Wei Yongjun Aug. 23, 2016, 3:06 p.m. UTC 
From: Wei Yongjun <weiyongjun1@huawei.com>

Fixes the following sparse warning:

drivers/net/phy/xilinx_gmii2rgmii.c:61:5: warning:
 symbol 'xgmiitorgmii_probe' was not declared. Should it be static?

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/net/phy/xilinx_gmii2rgmii.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andrew Lunn Aug. 23, 2016, 3:16 p.m. UTC | #1 
On Tue, Aug 23, 2016 at 03:06:05PM +0000, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>

Hi Wei

No need for the additional From:

git am will use the one in the mail header as the author of the patch,
and it is in the signed-off-by as well.

Thanks
    Andrew

> Fixes the following sparse warning:
> 
> drivers/net/phy/xilinx_gmii2rgmii.c:61:5: warning:
>  symbol 'xgmiitorgmii_probe' was not declared. Should it be static?
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
>  drivers/net/phy/xilinx_gmii2rgmii.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/phy/xilinx_gmii2rgmii.c b/drivers/net/phy/xilinx_gmii2rgmii.c
> index e7a20ec..2e408b8 100644
> --- a/drivers/net/phy/xilinx_gmii2rgmii.c
> +++ b/drivers/net/phy/xilinx_gmii2rgmii.c
> @@ -58,7 +58,7 @@ static int xgmiitorgmii_read_status(struct phy_device *phydev)
>  	return 0;
>  }
>  
> -int xgmiitorgmii_probe(struct mdio_device *mdiodev)
> +static int xgmiitorgmii_probe(struct mdio_device *mdiodev)
>  {
>  	struct device *dev = &mdiodev->dev;
>  	struct device_node *np = dev->of_node, *phy_node;
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Wei Yongjun Aug. 23, 2016, 3:41 p.m. UTC | #2 
Hi Andrew,

On 08/23/2016 11:16 PM, Andrew Lunn wrote:
> On Tue, Aug 23, 2016 at 03:06:05PM +0000, Wei Yongjun wrote:
>> From: Wei Yongjun <weiyongjun1@huawei.com>
> Hi Wei
>
> No need for the additional From:
>
> git am will use the one in the mail header as the author of the patch,
> and it is in the signed-off-by as well.

The mail address which I sent the patch is different with the
signed-of-by one, so git send-email will not remove the From line.

Regards,
Yongjun Wei
Andrew Lunn Aug. 23, 2016, 3:50 p.m. UTC | #3 
On Tue, Aug 23, 2016 at 11:41:25PM +0800, Wei Yongjun wrote:
> Hi Andrew,
> 
> On 08/23/2016 11:16 PM, Andrew Lunn wrote:
> > On Tue, Aug 23, 2016 at 03:06:05PM +0000, Wei Yongjun wrote:
> >> From: Wei Yongjun <weiyongjun1@huawei.com>
> > Hi Wei
> >
> > No need for the additional From:
> >
> > git am will use the one in the mail header as the author of the patch,
> > and it is in the signed-off-by as well.
> 
> The mail address which I sent the patch is different with the
> signed-of-by one, so git send-email will not remove the From line.

Cool. git am strips it out of the commit message and uses it as the
Author. I didn't know it did that.

Sorry for the noise, 

	Andrew
Kedari Appana Aug. 23, 2016, 4:40 p.m. UTC | #4 
HI,

        Thanks for the patch..

On Tue, Aug 23, 2016 at 8:36 PM, Wei Yongjun <weiyj.lk@gmail.com> wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fixes the following sparse warning:
>
> drivers/net/phy/xilinx_gmii2rgmii.c:61:5: warning:
>  symbol 'xgmiitorgmii_probe' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>

Acked by: Kedareswara rao Appana <appanad@xilinx.com>

> ---
>  drivers/net/phy/xilinx_gmii2rgmii.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/xilinx_gmii2rgmii.c b/drivers/net/phy/xilinx_gmii2rgmii.c
> index e7a20ec..2e408b8 100644
> --- a/drivers/net/phy/xilinx_gmii2rgmii.c
> +++ b/drivers/net/phy/xilinx_gmii2rgmii.c
> @@ -58,7 +58,7 @@ static int xgmiitorgmii_read_status(struct phy_device *phydev)
>         return 0;
>  }
>
> -int xgmiitorgmii_probe(struct mdio_device *mdiodev)
> +static int xgmiitorgmii_probe(struct mdio_device *mdiodev)
>  {
>         struct device *dev = &mdiodev->dev;
>         struct device_node *np = dev->of_node, *phy_node;
>
David Miller Aug. 24, 2016, 12:18 a.m. UTC | #5 
From: Wei Yongjun <weiyj.lk@gmail.com>
Date: Tue, 23 Aug 2016 15:06:05 +0000

> From: Wei Yongjun <weiyongjun1@huawei.com>
> 
> Fixes the following sparse warning:
> 
> drivers/net/phy/xilinx_gmii2rgmii.c:61:5: warning:
>  symbol 'xgmiitorgmii_probe' was not declared. Should it be static?
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>

Applied.
diff mbox

Patch

diff --git a/drivers/net/phy/xilinx_gmii2rgmii.c b/drivers/net/phy/xilinx_gmii2rgmii.c
index e7a20ec..2e408b8 100644
--- a/drivers/net/phy/xilinx_gmii2rgmii.c
+++ b/drivers/net/phy/xilinx_gmii2rgmii.c
@@ -58,7 +58,7 @@  static int xgmiitorgmii_read_status(struct phy_device *phydev)
 	return 0;
 }
 
-int xgmiitorgmii_probe(struct mdio_device *mdiodev)
+static int xgmiitorgmii_probe(struct mdio_device *mdiodev)
 {
 	struct device *dev = &mdiodev->dev;
 	struct device_node *np = dev->of_node, *phy_node;