diff mbox

ARM: OMAP: Overo: remove duplicate call to overo_ads7846_init()

Message ID 1308327432-31177-1-git-send-email-zonque@gmail.com (mailing list archive)
State Accepted
Commit 04a0b4a1401884531d8754b331313f41fefc9e27
Delegated to: Tony Lindgren
Headers show

Commit Message

Daniel Mack June 17, 2011, 4:17 p.m. UTC
overo_ads7846_init() is already called from overo_spi_init(), and
calling it twice is not only unnecessary but causes a warning as
"reg-fixed-voltage.1" is already added to the device tree.

Signed-off-by: Daniel Mack <zonque@gmail.com>
---
 arch/arm/mach-omap2/board-overo.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

Comments

Kevin Hilman June 17, 2011, 8:59 p.m. UTC | #1
Daniel Mack <zonque@gmail.com> writes:

> overo_ads7846_init() is already called from overo_spi_init(), and
> calling it twice is not only unnecessary but causes a warning as
> "reg-fixed-voltage.1" is already added to the device tree.

Excellent, thanks!

> Signed-off-by: Daniel Mack <zonque@gmail.com>

Tested-by: Kevin Hilman <khilman@ti.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Tony Lindgren July 1, 2011, 7:30 a.m. UTC | #2
* Kevin Hilman <khilman@ti.com> [110617 13:54]:
> Daniel Mack <zonque@gmail.com> writes:
> 
> > overo_ads7846_init() is already called from overo_spi_init(), and
> > calling it twice is not only unnecessary but causes a warning as
> > "reg-fixed-voltage.1" is already added to the device tree.
> 
> Excellent, thanks!
> 
> > Signed-off-by: Daniel Mack <zonque@gmail.com>
> 
> Tested-by: Kevin Hilman <khilman@ti.com>
> 

Applying into devel-fixes.

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/mach-omap2/board-overo.c b/arch/arm/mach-omap2/board-overo.c
index 175e1ab..110475f 100644
--- a/arch/arm/mach-omap2/board-overo.c
+++ b/arch/arm/mach-omap2/board-overo.c
@@ -568,7 +568,6 @@  static void __init overo_init(void)
 	usb_musb_init(NULL);
 	usbhs_init(&usbhs_bdata);
 	overo_spi_init();
-	overo_ads7846_init();
 	overo_init_smsc911x();
 	overo_display_init();
 	overo_init_led();