| Message ID | E1bamhf-0004XR-Nk@rmk-PC.armlinux.org.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, 19 Aug 2016, Russell King wrote: > ohci-omap doesn't need to include mach/irqs.h - nothing within this > driver needs anything from this header file. Remove this include. > > Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk> > --- > drivers/usb/host/ohci-omap.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/usb/host/ohci-omap.c b/drivers/usb/host/ohci-omap.c > index de7c68602a7e..495c1454b9e8 100644 > --- a/drivers/usb/host/ohci-omap.c > +++ b/drivers/usb/host/ohci-omap.c > @@ -36,7 +36,6 @@ > #include <mach/mux.h> > > #include <mach/hardware.h> > -#include <mach/irqs.h> > #include <mach/usb.h> Acked-by: Alan Stern <stern@rowland.harvard.edu>
On Mon, Aug 22, 2016 at 11:28:21AM -0400, Alan Stern wrote: > On Fri, 19 Aug 2016, Russell King wrote: > > > ohci-omap doesn't need to include mach/irqs.h - nothing within this > > driver needs anything from this header file. Remove this include. > > > > Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk> > > --- > > drivers/usb/host/ohci-omap.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/usb/host/ohci-omap.c b/drivers/usb/host/ohci-omap.c > > index de7c68602a7e..495c1454b9e8 100644 > > --- a/drivers/usb/host/ohci-omap.c > > +++ b/drivers/usb/host/ohci-omap.c > > @@ -36,7 +36,6 @@ > > #include <mach/mux.h> > > > > #include <mach/hardware.h> > > -#include <mach/irqs.h> > > #include <mach/usb.h> > > Acked-by: Alan Stern <stern@rowland.harvard.edu> Thanks. Will Greg be picking this up?
On Fri, 26 Aug 2016, Russell King - ARM Linux wrote: > On Mon, Aug 22, 2016 at 11:28:21AM -0400, Alan Stern wrote: > > On Fri, 19 Aug 2016, Russell King wrote: > > > > > ohci-omap doesn't need to include mach/irqs.h - nothing within this > > > driver needs anything from this header file. Remove this include. > > > > > > Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk> > > > --- > > > drivers/usb/host/ohci-omap.c | 1 - > > > 1 file changed, 1 deletion(-) > > > > > > diff --git a/drivers/usb/host/ohci-omap.c b/drivers/usb/host/ohci-omap.c > > > index de7c68602a7e..495c1454b9e8 100644 > > > --- a/drivers/usb/host/ohci-omap.c > > > +++ b/drivers/usb/host/ohci-omap.c > > > @@ -36,7 +36,6 @@ > > > #include <mach/mux.h> > > > > > > #include <mach/hardware.h> > > > -#include <mach/irqs.h> > > > #include <mach/usb.h> > > > > Acked-by: Alan Stern <stern@rowland.harvard.edu> > > Thanks. Will Greg be picking this up? Yes, he should. Unless you want it to go via a different tree... Alan Stern
On Fri, Aug 26, 2016 at 01:20:53PM -0400, Alan Stern wrote: > On Fri, 26 Aug 2016, Russell King - ARM Linux wrote: > > > On Mon, Aug 22, 2016 at 11:28:21AM -0400, Alan Stern wrote: > > > On Fri, 19 Aug 2016, Russell King wrote: > > > > > > > ohci-omap doesn't need to include mach/irqs.h - nothing within this > > > > driver needs anything from this header file. Remove this include. > > > > > > > > Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk> > > > > --- > > > > drivers/usb/host/ohci-omap.c | 1 - > > > > 1 file changed, 1 deletion(-) > > > > > > > > diff --git a/drivers/usb/host/ohci-omap.c b/drivers/usb/host/ohci-omap.c > > > > index de7c68602a7e..495c1454b9e8 100644 > > > > --- a/drivers/usb/host/ohci-omap.c > > > > +++ b/drivers/usb/host/ohci-omap.c > > > > @@ -36,7 +36,6 @@ > > > > #include <mach/mux.h> > > > > > > > > #include <mach/hardware.h> > > > > -#include <mach/irqs.h> > > > > #include <mach/usb.h> > > > > > > Acked-by: Alan Stern <stern@rowland.harvard.edu> > > > > Thanks. Will Greg be picking this up? > > Yes, he should. Unless you want it to go via a different tree... I'm fine with Greg picking this (and the other two) up as none of my (increasing) patch stack depends on these patches.
On Fri, Aug 26, 2016 at 07:05:19PM +0100, Russell King - ARM Linux wrote: > On Fri, Aug 26, 2016 at 01:20:53PM -0400, Alan Stern wrote: > > On Fri, 26 Aug 2016, Russell King - ARM Linux wrote: > > > > > On Mon, Aug 22, 2016 at 11:28:21AM -0400, Alan Stern wrote: > > > > On Fri, 19 Aug 2016, Russell King wrote: > > > > > > > > > ohci-omap doesn't need to include mach/irqs.h - nothing within this > > > > > driver needs anything from this header file. Remove this include. > > > > > > > > > > Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk> > > > > > --- > > > > > drivers/usb/host/ohci-omap.c | 1 - > > > > > 1 file changed, 1 deletion(-) > > > > > > > > > > diff --git a/drivers/usb/host/ohci-omap.c b/drivers/usb/host/ohci-omap.c > > > > > index de7c68602a7e..495c1454b9e8 100644 > > > > > --- a/drivers/usb/host/ohci-omap.c > > > > > +++ b/drivers/usb/host/ohci-omap.c > > > > > @@ -36,7 +36,6 @@ > > > > > #include <mach/mux.h> > > > > > > > > > > #include <mach/hardware.h> > > > > > -#include <mach/irqs.h> > > > > > #include <mach/usb.h> > > > > > > > > Acked-by: Alan Stern <stern@rowland.harvard.edu> > > > > > > Thanks. Will Greg be picking this up? > > > > Yes, he should. Unless you want it to go via a different tree... > > I'm fine with Greg picking this (and the other two) up as none > of my (increasing) patch stack depends on these patches. Ok, I'll take it in my next round, thanks. greg k-h
diff --git a/drivers/usb/host/ohci-omap.c b/drivers/usb/host/ohci-omap.c index de7c68602a7e..495c1454b9e8 100644 --- a/drivers/usb/host/ohci-omap.c +++ b/drivers/usb/host/ohci-omap.c @@ -36,7 +36,6 @@ #include <mach/mux.h> #include <mach/hardware.h> -#include <mach/irqs.h> #include <mach/usb.h>
ohci-omap doesn't need to include mach/irqs.h - nothing within this driver needs anything from this header file. Remove this include. Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk> --- drivers/usb/host/ohci-omap.c | 1 - 1 file changed, 1 deletion(-)