| Message ID | 1472321697-3094-4-git-send-email-prasannatsmkumar@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Herbert Xu |
| Headers | show |
Hello. On 8/27/2016 9:14 PM, PrasannaKumar Muralidharan wrote: > This patch adds RNG node to jz4780.dtsi. > > Signed-off-by: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com> > --- > arch/mips/boot/dts/ingenic/jz4780.dtsi | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi b/arch/mips/boot/dts/ingenic/jz4780.dtsi > index b868b42..f11d139 100644 > --- a/arch/mips/boot/dts/ingenic/jz4780.dtsi > +++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi > @@ -36,7 +36,7 @@ > > cgu: jz4780-cgu@10000000 { > compatible = "ingenic,jz4780-cgu"; > - reg = <0x10000000 0x100>; > + reg = <0x10000000 0xD8>; I think lower case is preferred here. > > clocks = <&ext>, <&rtc>; > clock-names = "ext", "rtc"; > @@ -44,6 +44,11 @@ > #clock-cells = <1>; > }; > > + rng: jz4780-rng@100000D8 { All in lower case, please. > + compatible = "ingenic,jz4780-rng"; > + reg = <0x100000D8 0x8>; Likewise. [...] MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
>> cgu: jz4780-cgu@10000000 { >> compatible = "ingenic,jz4780-cgu"; >> - reg = <0x10000000 0x100>; >> + reg = <0x10000000 0xD8>; > > > I think lower case is preferred here. Sure, will change. -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 27/08/16 19:14, PrasannaKumar Muralidharan wrote: > This patch adds RNG node to jz4780.dtsi. > > Signed-off-by: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com> > --- > arch/mips/boot/dts/ingenic/jz4780.dtsi | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi b/arch/mips/boot/dts/ingenic/jz4780.dtsi > index b868b42..f11d139 100644 > --- a/arch/mips/boot/dts/ingenic/jz4780.dtsi > +++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi > @@ -36,7 +36,7 @@ > > cgu: jz4780-cgu@10000000 { > compatible = "ingenic,jz4780-cgu"; > - reg = <0x10000000 0x100>; > + reg = <0x10000000 0xD8>; Hi PrasannaKumar, I don't like this change. The RNG registers are documented as a part of the same hardware block as the clock & power stuff which the CGU driver handles, and indeed in the M200 SoC there is a power-related register after the RNG registers. So shortening the range covered by the CGU driver is not the right way to go. Perhaps you could instead have the CGU driver make use of the syscon infrastructure to expose a regmap which your RNG driver could pick up & use? Thanks, Paul > > clocks = <&ext>, <&rtc>; > clock-names = "ext", "rtc"; > @@ -44,6 +44,11 @@ > #clock-cells = <1>; > }; > > + rng: jz4780-rng@100000D8 { > + compatible = "ingenic,jz4780-rng"; > + reg = <0x100000D8 0x8>; > + }; > + > uart0: serial@10030000 { > compatible = "ingenic,jz4780-uart"; > reg = <0x10030000 0x100>; > -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> I don't like this change. The RNG registers are documented as a part of > the same hardware block as the clock & power stuff which the CGU driver > handles, and indeed in the M200 SoC there is a power-related register > after the RNG registers. So shortening the range covered by the CGU > driver is not the right way to go. Could not find M200 SoC PM in ingenic's website or ftp. So did not notice this. > Perhaps you could instead have the CGU driver make use of the syscon > infrastructure to expose a regmap which your RNG driver could pick up & use? I will see how to use syscon and provide an updated patch. -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi b/arch/mips/boot/dts/ingenic/jz4780.dtsi index b868b42..f11d139 100644 --- a/arch/mips/boot/dts/ingenic/jz4780.dtsi +++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi @@ -36,7 +36,7 @@ cgu: jz4780-cgu@10000000 { compatible = "ingenic,jz4780-cgu"; - reg = <0x10000000 0x100>; + reg = <0x10000000 0xD8>; clocks = <&ext>, <&rtc>; clock-names = "ext", "rtc"; @@ -44,6 +44,11 @@ #clock-cells = <1>; }; + rng: jz4780-rng@100000D8 { + compatible = "ingenic,jz4780-rng"; + reg = <0x100000D8 0x8>; + }; + uart0: serial@10030000 { compatible = "ingenic,jz4780-uart"; reg = <0x10030000 0x100>;
This patch adds RNG node to jz4780.dtsi. Signed-off-by: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com> --- arch/mips/boot/dts/ingenic/jz4780.dtsi | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)