| Message ID | 1471502328-28305-5-git-send-email-yao.yuan@freescale.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
On Thursday 18 August 2016 14:38:47, Yuan Yao wrote: > From: Yuan Yao <yao.yuan@nxp.com> > > Add the QDMA node for ls1043a platform to > support QDMA driver. > > Signed-off-by: Yuan Yao <yao.yuan@nxp.com> > --- > arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi > b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi index e8e4c3e..e463074 > 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi > @@ -467,6 +467,16 @@ > <&clockgen 4 0>; > }; > > + qdma: qdma@8390000 { > + compatible = "fsl,ls1021a-qdma", "fsl,ls1043a-qdma"; This doesn't match the order of your binding in Patch 2/5: > +- compatible : > + - "fsl,ls1021a-qdma", > + Or "fsl,ls1043a-qdma" followed by "fsl,ls1021a-qdma", It should be the other way around. Best regards, Alexander -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thursday 18 August 2016 14:38:47, Yuan Yao wrote: > From: Yuan Yao <yao.yuan@nxp.com> > > Add the QDMA node for ls1043a platform to > support QDMA driver. > > Signed-off-by: Yuan Yao <yao.yuan@nxp.com> > --- > arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi > b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi index e8e4c3e..e463074 > 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi > @@ -467,6 +467,16 @@ > <&clockgen 4 0>; > }; > > + qdma: qdma@8390000 { > + compatible = "fsl,ls1021a-qdma", "fsl,ls1043a-qdma"; This doesn't match the order of your binding in Patch 2/5: > +- compatible : > + - "fsl,ls1021a-qdma", > + Or "fsl,ls1043a-qdma" followed by "fsl,ls1021a-qdma", It should be the other way around. Best regards, Alexander -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon 29 August 2016 03:34:47, : Alexander Stein wrote: > On Thursday 18 August 2016 14:38:47, Yuan Yao wrote: > > From: Yuan Yao <yao.yuan@nxp.com> > > > > Add the QDMA node for ls1043a platform to support QDMA driver. > > > > Signed-off-by: Yuan Yao <yao.yuan@nxp.com> > > --- > > arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi > > b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi index > > e8e4c3e..e463074 > > 100644 > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi > > @@ -467,6 +467,16 @@ > > <&clockgen 4 0>; > > }; > > > > + qdma: qdma@8390000 { > > + compatible = "fsl,ls1021a-qdma", "fsl,ls1043a-qdma"; > > This doesn't match the order of your binding in Patch 2/5: > > +- compatible : > > + - "fsl,ls1021a-qdma", > > + Or "fsl,ls1043a-qdma" followed by "fsl,ls1021a-qdma", > > It should be the other way around. Thanks for your review. It should be compatible = "fsl,ls1043a-qspi", "fsl,ls1021a-qspi"; I will update it in the next version. Thanks. -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi index e8e4c3e..e463074 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi @@ -467,6 +467,16 @@ <&clockgen 4 0>; }; + qdma: qdma@8390000 { + compatible = "fsl,ls1021a-qdma", "fsl,ls1043a-qdma"; + reg = <0x0 0x838f000 0x0 0x11000 /* Controller regs */ + 0x0 0x83a0000 0x0 0x40000>; /* Block regs */ + interrupts = <0 153 0x4>, + <0 39 0x4>; + interrupt-names = "qdma-error", "qdma-queue"; + big-endian; + }; + usb0: usb3@2f00000 { compatible = "snps,dwc3"; reg = <0x0 0x2f00000 0x0 0x10000>;