| Message ID | 6111feb57b5fbaa29eeb6ba089bb2824bbf2f8ff.1473833908.git.maitysanchayan@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 2016-09-13 23:35, Sanchayan Maity wrote: > Remove use of pwm-leds and use the standard /sys/class/pwm > interface from PWM subsystem. Don't we have actual leds on the Ixora? -- Stefan > > Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com> > --- > arch/arm/boot/dts/imx6q-apalis-ixora.dts | 22 ---------------------- > 1 file changed, 22 deletions(-) > > diff --git a/arch/arm/boot/dts/imx6q-apalis-ixora.dts > b/arch/arm/boot/dts/imx6q-apalis-ixora.dts > index d99979e..70a3da0 100644 > --- a/arch/arm/boot/dts/imx6q-apalis-ixora.dts > +++ b/arch/arm/boot/dts/imx6q-apalis-ixora.dts > @@ -146,28 +146,6 @@ > gpios = <&gpio2 2 GPIO_ACTIVE_HIGH>; > }; > }; > - > - pwmleds { > - compatible = "pwm-leds"; > - > - ledpwm1 { > - label = "PWM1"; > - pwms = <&pwm1 0 50000>; > - max-brightness = <255>; > - }; > - > - ledpwm2 { > - label = "PWM2"; > - pwms = <&pwm2 0 50000>; > - max-brightness = <255>; > - }; > - > - ledpwm3 { > - label = "PWM3"; > - pwms = <&pwm3 0 50000>; > - max-brightness = <255>; > - }; > - }; > }; > > &backlight {
On Wed, 2016-09-14 at 08:58 -0700, Stefan Agner wrote: > On 2016-09-13 23:35, Sanchayan Maity wrote: > > > > Remove use of pwm-leds and use the standard /sys/class/pwm > > interface from PWM subsystem. > Don't we have actual leds on the Ixora? Yes, sure, but not really PWM ones: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/ar ch/arm/boot/dts/imx6q-apalis-ixora.dts?id=refs/tags/v4.8-rc6#n124
On Wed, 2016-09-14 at 12:05 +0530, Sanchayan Maity wrote: > Remove use of pwm-leds and use the standard /sys/class/pwm > interface from PWM subsystem. > > Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com> Acked-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> > --- > arch/arm/boot/dts/imx6q-apalis-ixora.dts | 22 ---------------------- > 1 file changed, 22 deletions(-) > > diff --git a/arch/arm/boot/dts/imx6q-apalis-ixora.dts > b/arch/arm/boot/dts/imx6q-apalis-ixora.dts > index d99979e..70a3da0 100644 > --- a/arch/arm/boot/dts/imx6q-apalis-ixora.dts > +++ b/arch/arm/boot/dts/imx6q-apalis-ixora.dts > @@ -146,28 +146,6 @@ > gpios = <&gpio2 2 GPIO_ACTIVE_HIGH>; > }; > }; > - > - pwmleds { > - compatible = "pwm-leds"; > - > - ledpwm1 { > - label = "PWM1"; > - pwms = <&pwm1 0 50000>; > - max-brightness = <255>; > - }; > - > - ledpwm2 { > - label = "PWM2"; > - pwms = <&pwm2 0 50000>; > - max-brightness = <255>; > - }; > - > - ledpwm3 { > - label = "PWM3"; > - pwms = <&pwm3 0 50000>; > - max-brightness = <255>; > - }; > - }; > }; > > &backlight { Tested working fine analogous to what we documented for Vybrid: http://developer.toradex.com/knowledge-base/pwm-(linux)#Colibri_VFxx
diff --git a/arch/arm/boot/dts/imx6q-apalis-ixora.dts b/arch/arm/boot/dts/imx6q-apalis-ixora.dts index d99979e..70a3da0 100644 --- a/arch/arm/boot/dts/imx6q-apalis-ixora.dts +++ b/arch/arm/boot/dts/imx6q-apalis-ixora.dts @@ -146,28 +146,6 @@ gpios = <&gpio2 2 GPIO_ACTIVE_HIGH>; }; }; - - pwmleds { - compatible = "pwm-leds"; - - ledpwm1 { - label = "PWM1"; - pwms = <&pwm1 0 50000>; - max-brightness = <255>; - }; - - ledpwm2 { - label = "PWM2"; - pwms = <&pwm2 0 50000>; - max-brightness = <255>; - }; - - ledpwm3 { - label = "PWM3"; - pwms = <&pwm3 0 50000>; - max-brightness = <255>; - }; - }; }; &backlight {
Remove use of pwm-leds and use the standard /sys/class/pwm interface from PWM subsystem. Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com> --- arch/arm/boot/dts/imx6q-apalis-ixora.dts | 22 ---------------------- 1 file changed, 22 deletions(-)