diff mbox

[15/30] dmaengine: omap-dma: enable COMPILE_TEST

Message ID 1473960849-23024-16-git-send-email-vinod.koul@intel.com (mailing list archive)
State Superseded
Headers show

Commit Message

Vinod Koul Sept. 15, 2016, 5:33 p.m. UTC
To get more coverage, enable COMPILE_TEST for this driver.

Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
---
 drivers/dma/Kconfig | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Peter Ujfalusi Sept. 16, 2016, 7:40 a.m. UTC | #1
Vinod,

On 09/15/16 20:33, Vinod Koul wrote:
> To get more coverage, enable COMPILE_TEST for this driver.

I prepared a series to enable the compile testing unconditionally, can you
drop this patch and I will send a series to allow compile testing omap-dma and
edma on all architecture.

> Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
> ---
>  drivers/dma/Kconfig | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> index f68958ef9431..ee81c7b810bd 100644
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> @@ -129,8 +129,9 @@ config DMA_JZ4780
>  	  devices which can use the DMA controller, say Y or M here.
>  
>  config DMA_OMAP
> -	tristate "OMAP DMA support"
> -	depends on ARCH_OMAP
> +	tristate "OMAP DMA support" if COMPILE_TEST && !ARCH_OMAP
> +	default ARCH_OMAP
> +	depends on ARCH_ARM
>  	select DMA_ENGINE
>  	select DMA_VIRTUAL_CHANNELS
>  	select TI_DMA_CROSSBAR if SOC_DRA7XX
>
Arnd Bergmann Sept. 16, 2016, 7:41 a.m. UTC | #2
On Thursday, September 15, 2016 11:03:54 PM CEST Vinod Koul wrote:
> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> index f68958ef9431..ee81c7b810bd 100644
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> @@ -129,8 +129,9 @@ config DMA_JZ4780
>           devices which can use the DMA controller, say Y or M here.
>  
>  config DMA_OMAP
> -       tristate "OMAP DMA support"
> -       depends on ARCH_OMAP
> +       tristate "OMAP DMA support" if COMPILE_TEST && !ARCH_OMAP
> +       default ARCH_OMAP
> +       depends on ARCH_ARM
> 

s/ARCH_ARM/ARM/

	Arnd

--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Vinod Koul Sept. 16, 2016, 2:21 p.m. UTC | #3
On Fri, Sep 16, 2016 at 10:40:17AM +0300, Peter Ujfalusi wrote:
> Vinod,
> 
> On 09/15/16 20:33, Vinod Koul wrote:
> > To get more coverage, enable COMPILE_TEST for this driver.
> 
> I prepared a series to enable the compile testing unconditionally, can you
> drop this patch and I will send a series to allow compile testing omap-dma and
> edma on all architecture.

Sounds fine to me :). I will drop this one.
diff mbox

Patch

diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
index f68958ef9431..ee81c7b810bd 100644
--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -129,8 +129,9 @@  config DMA_JZ4780
 	  devices which can use the DMA controller, say Y or M here.
 
 config DMA_OMAP
-	tristate "OMAP DMA support"
-	depends on ARCH_OMAP
+	tristate "OMAP DMA support" if COMPILE_TEST && !ARCH_OMAP
+	default ARCH_OMAP
+	depends on ARCH_ARM
 	select DMA_ENGINE
 	select DMA_VIRTUAL_CHANNELS
 	select TI_DMA_CROSSBAR if SOC_DRA7XX