| Message ID | 20160915191550.12371-2-vbatts@hashbangbash.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Thu, Sep 15, 2016 at 03:15:50PM -0400, Vincent Batts wrote: > There was already the logic for verbose output, but the flag parsing did > not include it. > > Signed-off-by: Vincent Batts <vbatts@hashbangbash.com> Applied, thanks. I wonder where the original argument got lost. In the commit 2ed161bd281beca29feebebbc8c4227cc6e918c3 it to added to getopt but inside cmd_subvol_create. I'll fix it as well. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 19/09/16 19:41 +0200, David Sterba wrote: >Applied, thanks. I wonder where the original argument got lost. In the >commit 2ed161bd281beca29feebebbc8c4227cc6e918c3 it to added to getopt >but inside cmd_subvol_create. I'll fix it as well. Not sure. I found it while investigating feasibility of adding a flag to recursively delete subvolumes. Which, do you have particular feelings about recursive deletes? -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/cmds-subvolume.c b/cmds-subvolume.c index e7ef67d..f8c9f48 100644 --- a/cmds-subvolume.c +++ b/cmds-subvolume.c @@ -245,6 +245,7 @@ static const char * const cmd_subvol_delete_usage[] = { "", "-c|--commit-after wait for transaction commit at the end of the operation", "-C|--commit-each wait for transaction commit after deleting each subvolume", + "-v|--verbose verbose output of operations", NULL }; @@ -267,10 +268,11 @@ static int cmd_subvol_delete(int argc, char **argv) static const struct option long_options[] = { {"commit-after", no_argument, NULL, 'c'}, /* commit mode 1 */ {"commit-each", no_argument, NULL, 'C'}, /* commit mode 2 */ + {"verbose", no_argument, NULL, 'v'}, {NULL, 0, NULL, 0} }; - c = getopt_long(argc, argv, "cC", long_options, NULL); + c = getopt_long(argc, argv, "cCv", long_options, NULL); if (c < 0) break;
There was already the logic for verbose output, but the flag parsing did not include it. Signed-off-by: Vincent Batts <vbatts@hashbangbash.com> --- cmds-subvolume.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)