| Message ID | e74ecf81-1ddc-2583-3a4b-48735e2898c4@users.sourceforge.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 09/22/16 11:32, SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Thu, 22 Sep 2016 09:29:23 +0200 > > Return directly after a memory allocation failed in this function > at the beginning. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c b/drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c > index 8faa28f..6204405 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c > +++ b/drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c > @@ -206,7 +206,7 @@ void __init tilcdc_convert_slave_node(void) > int ret; > > if (kfree_table_init(&kft)) > - goto out; > + return; > > lcdc = of_find_matching_node(NULL, tilcdc_of_match); > slave = of_find_matching_node(NULL, tilcdc_slave_of_match); > Thanks, This is a real bug. I'll pick this up, but with your permission I change the commit subject to follow the current convention. Best regards, Jyri
> I'll pick this up, but with your permission I change > the commit subject to follow the current convention. I guess that I can accept the integration of this update suggestion also with an adjusted prefix in the commit title. ;-) Regards, Markus
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c b/drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c index 8faa28f..6204405 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c +++ b/drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c @@ -206,7 +206,7 @@ void __init tilcdc_convert_slave_node(void) int ret; if (kfree_table_init(&kft)) - goto out; + return; lcdc = of_find_matching_node(NULL, tilcdc_of_match); slave = of_find_matching_node(NULL, tilcdc_slave_of_match);