| Message ID | 1474560996-20863-1-git-send-email-sean.wang@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 09/22/2016 07:16 PM, sean.wang@mediatek.com wrote: > From: Sean Wang <sean.wang@mediatek.com> > > fix typo in mediatek-net.txt and add phy-mode "trgmii" to ethernet.txt These changes are unrelated to each other, so there should be 2 separate patches. And have the patches I reviewed been merged already, why are you sending an incremental patch? > Cc: devicetree@vger.kernel.org > Reported-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > Signed-off-by: Sean Wang <sean.wang@mediatek.com> [...] MBR, Sergei
Date: Thu, 22 Sep 2016 19:48:47 +0300, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote: >On 09/22/2016 07:16 PM, sean.wang@mediatek.com wrote: > >> From: Sean Wang <sean.wang@mediatek.com> >> >> fix typo in mediatek-net.txt and add phy-mode "trgmii" to ethernet.txt > > These changes are unrelated to each other, so there should be 2 separate >patches. And have the patches I reviewed been merged already, why are you >sending an incremental patch? > okay, I will make them into distinct patchs. I saw they had been applied so I created an incremental patch based on codebase after applied. >> Cc: devicetree@vger.kernel.org >> Reported-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> >> Signed-off-by: Sean Wang <sean.wang@mediatek.com> >[...] > >MBR, Sergei > >
diff --git a/Documentation/devicetree/bindings/net/ethernet.txt b/Documentation/devicetree/bindings/net/ethernet.txt index 5d88f37..e1d7681 100644 --- a/Documentation/devicetree/bindings/net/ethernet.txt +++ b/Documentation/devicetree/bindings/net/ethernet.txt @@ -11,8 +11,8 @@ The following properties are common to the Ethernet controllers: the maximum frame size (there's contradiction in ePAPR). - phy-mode: string, operation mode of the PHY interface; supported values are "mii", "gmii", "sgmii", "qsgmii", "tbi", "rev-mii", "rmii", "rgmii", "rgmii-id", - "rgmii-rxid", "rgmii-txid", "rtbi", "smii", "xgmii"; this is now a de-facto - standard property; + "rgmii-rxid", "rgmii-txid", "rtbi", "smii", "xgmii", "trgmii"; this is now a + de-facto standard property; - phy-connection-type: the same as "phy-mode" property but described in ePAPR; - phy-handle: phandle, specifies a reference to a node representing a PHY device; this property is described in ePAPR and so preferred; diff --git a/Documentation/devicetree/bindings/net/mediatek-net.txt b/Documentation/devicetree/bindings/net/mediatek-net.txt index bae848e..da05f8b 100644 --- a/Documentation/devicetree/bindings/net/mediatek-net.txt +++ b/Documentation/devicetree/bindings/net/mediatek-net.txt @@ -34,7 +34,7 @@ Required properties: - phy-handle: see ethernet.txt file in the same directory and the phy-mode "trgmii" required being provided when reg is equal to 0 and the MAC uses fixed-link to connect - with inernal switch such as MT7530. + with internal switch such as MT7530. Example: