| Message ID | 7ff91d13-9111-c75a-1c1a-e119025866e7@users.sourceforge.net (mailing list archive) |
|---|---|
| State | Rejected |
| Headers | show |
On Sat, Sep 24, 2016 at 03:46:21PM +0200, SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Sat, 24 Sep 2016 13:50:20 +0200 > > * A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "kmalloc_array". > -ENOPARSE. > This issue was detected by using the Coccinelle software. > > * Replace the specification of a data structure by a pointer dereference > to make the corresponding size determination a bit safer according to > the Linux coding style convention. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > drivers/input/joystick/joydump.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/input/joystick/joydump.c b/drivers/input/joystick/joydump.c > index d1c6e48..e515058 100644 > --- a/drivers/input/joystick/joydump.c > +++ b/drivers/input/joystick/joydump.c > @@ -79,8 +79,7 @@ static int joydump_connect(struct gameport *gameport, struct gameport_driver *dr > } > > timeout = gameport_time(gameport, 10000); /* 10 ms */ > - > - buf = kmalloc(BUF_SIZE * sizeof(struct joydump), GFP_KERNEL); > + buf = kmalloc_array(BUF_SIZE, sizeof(*buf), GFP_KERNEL); > if (!buf) { > printk(KERN_INFO "joydump: no memory for testing\n"); > goto jd_end; > -- > 2.10.0 >
>> * A multiplication for the size determination of a memory allocation >> indicated that an array data structure should be processed. >> Thus use the corresponding function "kmalloc_array". >> > > -ENOPARSE. Do you find an other wording better? The script "checkpatch.pl" can point information out like the following. WARNING: Prefer kmalloc_array over kmalloc with multiply Regards, Markus -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/input/joystick/joydump.c b/drivers/input/joystick/joydump.c index d1c6e48..e515058 100644 --- a/drivers/input/joystick/joydump.c +++ b/drivers/input/joystick/joydump.c @@ -79,8 +79,7 @@ static int joydump_connect(struct gameport *gameport, struct gameport_driver *dr } timeout = gameport_time(gameport, 10000); /* 10 ms */ - - buf = kmalloc(BUF_SIZE * sizeof(struct joydump), GFP_KERNEL); + buf = kmalloc_array(BUF_SIZE, sizeof(*buf), GFP_KERNEL); if (!buf) { printk(KERN_INFO "joydump: no memory for testing\n"); goto jd_end;