| Message ID | 65ed528f-7ec5-a0f2-6219-3e63a78ca0ee@users.sourceforge.net (mailing list archive) |
|---|---|
| State | Rejected |
| Delegated to: | Kalle Valo |
| Headers | show |
Hi Marcus, On Sun, Aug 21, 2016 at 2:46 AM, SF Markus Elfring <elfring@users.sourceforge.net> wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Sat, 20 Aug 2016 18:21:29 +0200 > > Remove a jump label which is unneeded in this function at the end. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > drivers/net/wireless/intersil/hostap/hostap_ioctl.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/wireless/intersil/hostap/hostap_ioctl.c b/drivers/net/wireless/intersil/hostap/hostap_ioctl.c > index 4e271f9..5942917 100644 > --- a/drivers/net/wireless/intersil/hostap/hostap_ioctl.c > +++ b/drivers/net/wireless/intersil/hostap/hostap_ioctl.c > @@ -3835,14 +3835,12 @@ static int prism2_ioctl_priv_hostapd(local_info_t *local, struct iw_point *p) > } > > if (ret == 1 || !ap_ioctl) { > - if (copy_to_user(p->pointer, param, p->length)) { > + if (copy_to_user(p->pointer, param, p->length)) > ret = -EFAULT; > - goto out; > - } else if (ap_ioctl) > + else if (ap_ioctl) > ret = 0; > } > > - out: Does this change make any difference to the compiled code? Thanks,
SF Markus Elfring <elfring@users.sourceforge.net> wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Sat, 20 Aug 2016 18:21:29 +0200 > > Remove a jump label which is unneeded in this function at the end. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> 2 patches set to Rejected. 9291771 [2/3] hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd() 9291775 [3/3] hostap: Delete unnecessary initialisations for the variable "ret" Reason: The benefit is not clear.
> 9291771 [2/3] hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd() > 9291775 [3/3] hostap: Delete unnecessary initialisations for the variable "ret" > > Reason: The benefit is not clear. How do you think about to reduce the source code a bit at these places? Regards, Markus
SF Markus Elfring <elfring@users.sourceforge.net> writes: >> 9291771 [2/3] hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd() >> 9291775 [3/3] hostap: Delete unnecessary initialisations for the variable "ret" >> >> Reason: The benefit is not clear. > > How do you think about to reduce the source code a bit at these places? hostap is an obsolete driver, it's waste of time doing style fixes to it as nobody maintains it anymore.
> hostap is an obsolete driver, it's waste of time doing style fixes to it > as nobody maintains it anymore. Thanks for another bit of your software development attention and this information. Is it easier to understand than the previous response "Reason: The benefit is not clear."? Regards, Markus
diff --git a/drivers/net/wireless/intersil/hostap/hostap_ioctl.c b/drivers/net/wireless/intersil/hostap/hostap_ioctl.c index 4e271f9..5942917 100644 --- a/drivers/net/wireless/intersil/hostap/hostap_ioctl.c +++ b/drivers/net/wireless/intersil/hostap/hostap_ioctl.c @@ -3835,14 +3835,12 @@ static int prism2_ioctl_priv_hostapd(local_info_t *local, struct iw_point *p) } if (ret == 1 || !ap_ioctl) { - if (copy_to_user(p->pointer, param, p->length)) { + if (copy_to_user(p->pointer, param, p->length)) ret = -EFAULT; - goto out; - } else if (ap_ioctl) + else if (ap_ioctl) ret = 0; } - out: kfree(param); return ret; }