| Message ID | 1474311771-23321-3-git-send-email-ayaka@soulik.info (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Sep 20, 2016 at 03:02:51AM +0800, Randy Li wrote: > The Chunghwa CLAA070WP03XG is a 7" 1280x800 panel, which can be > supported by the simple panel driver. > > Signed-off-by: Randy Li <ayaka@soulik.info> > --- > .../display/panel/chunghwa,claa070wp03xg.txt | 7 ++++++ > drivers/gpu/drm/panel/panel-simple.c | 27 ++++++++++++++++++++++ > 2 files changed, 34 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt > > diff --git a/Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt b/Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt > new file mode 100644 > index 0000000..dd22685 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt > @@ -0,0 +1,7 @@ > +Chunghwa Picture Tubes Ltd. 7" WXGA TFT LCD panel > + > +Required properties: > +- compatible: should be "chunghwa,claa070wp03xg" What about VCC, VLED, LED_EN (PWM), LVBIT, LVFMT, DITHER signals? > + > +This binding is compatible with the simple-panel binding, which is specified > +in simple-panel.txt in this directory.
On 09/24/2016 02:00 AM, Rob Herring wrote: > On Tue, Sep 20, 2016 at 03:02:51AM +0800, Randy Li wrote: >> The Chunghwa CLAA070WP03XG is a 7" 1280x800 panel, which can be >> supported by the simple panel driver. >> >> Signed-off-by: Randy Li <ayaka@soulik.info> >> --- >> .../display/panel/chunghwa,claa070wp03xg.txt | 7 ++++++ >> drivers/gpu/drm/panel/panel-simple.c | 27 ++++++++++++++++++++++ >> 2 files changed, 34 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt >> >> diff --git a/Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt b/Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt >> new file mode 100644 >> index 0000000..dd22685 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt >> @@ -0,0 +1,7 @@ >> +Chunghwa Picture Tubes Ltd. 7" WXGA TFT LCD panel >> + >> +Required properties: >> +- compatible: should be "chunghwa,claa070wp03xg" > What about VCC, VLED, LED_EN (PWM), LVBIT, LVFMT, DITHER signals? I didn't see the other simple-panel has that, so I didn't neither. And I think it would only have VCC and LED_EN(PWM). > >> + >> +This binding is compatible with the simple-panel binding, which is specified >> +in simple-panel.txt in this directory.
On Tue, Sep 20, 2016 at 03:02:51AM +0800, Randy Li wrote: > The Chunghwa CLAA070WP03XG is a 7" 1280x800 panel, which can be > supported by the simple panel driver. > > Signed-off-by: Randy Li <ayaka@soulik.info> > --- > .../display/panel/chunghwa,claa070wp03xg.txt | 7 ++++++ > drivers/gpu/drm/panel/panel-simple.c | 27 ++++++++++++++++++++++ > 2 files changed, 34 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt Applied, thanks. Thierry
從我的 iPad 傳送 > Thierry Reding <thierry.reding@gmail.com> 於 2016年12月6日 下午11:46 寫道： > >> On Tue, Sep 20, 2016 at 03:02:51AM +0800, Randy Li wrote: >> The Chunghwa CLAA070WP03XG is a 7" 1280x800 panel, which can be >> supported by the simple panel driver. >> >> Signed-off-by: Randy Li <ayaka@soulik.info> >> --- >> .../display/panel/chunghwa,claa070wp03xg.txt | 7 ++++++ >> drivers/gpu/drm/panel/panel-simple.c | 27 ++++++++++++++++++++++ >> 2 files changed, 34 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt > > Applied, thanks. Wait, it is RFC, not pass the test. > > Thierry
On Wed, Dec 07, 2016 at 08:57:23AM +0800, Ayaka wrote: > > > 從我的 iPad 傳送 > > > Thierry Reding <thierry.reding@gmail.com> 於 2016年12月6日 下午11:46 寫道： > > > >> On Tue, Sep 20, 2016 at 03:02:51AM +0800, Randy Li wrote: > >> The Chunghwa CLAA070WP03XG is a 7" 1280x800 panel, which can be > >> supported by the simple panel driver. > >> > >> Signed-off-by: Randy Li <ayaka@soulik.info> > >> --- > >> .../display/panel/chunghwa,claa070wp03xg.txt | 7 ++++++ > >> drivers/gpu/drm/panel/panel-simple.c | 27 ++++++++++++++++++++++ > >> 2 files changed, 34 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt > > > > Applied, thanks. > Wait, it is RFC, not pass the test. Well 2 months of silence, it's reasonable to assume that this works for you ... I guess you need to supply a fixup patch asap ;-) -Daniel
On 12/07/2016 10:55 PM, Daniel Vetter wrote: > On Wed, Dec 07, 2016 at 08:57:23AM +0800, Ayaka wrote: >> >> 從我的 iPad 傳送 >> >>> Thierry Reding <thierry.reding@gmail.com> 於 2016年12月6日 下午11:46 寫道： >>> >>>> On Tue, Sep 20, 2016 at 03:02:51AM +0800, Randy Li wrote: >>>> The Chunghwa CLAA070WP03XG is a 7" 1280x800 panel, which can be >>>> supported by the simple panel driver. >>>> >>>> Signed-off-by: Randy Li <ayaka@soulik.info> >>>> --- >>>> .../display/panel/chunghwa,claa070wp03xg.txt | 7 ++++++ >>>> drivers/gpu/drm/panel/panel-simple.c | 27 ++++++++++++++++++++++ >>>> 2 files changed, 34 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt >>> Applied, thanks. >> Wait, it is RFC, not pass the test. > Well 2 months of silence, it's reasonable to assume that this works for > you ... I guess you need to supply a fixup patch asap ;-) Sorry, my exynos 4412 board is broken, I will order one and fix this problem, please don't merge this patch until somebody confirm that it is adjusted to correct parameter. > -Daniel
diff --git a/Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt b/Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt new file mode 100644 index 0000000..dd22685 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt @@ -0,0 +1,7 @@ +Chunghwa Picture Tubes Ltd. 7" WXGA TFT LCD panel + +Required properties: +- compatible: should be "chunghwa,claa070wp03xg" + +This binding is compatible with the simple-panel binding, which is specified +in simple-panel.txt in this directory. diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index f178998..3204e6b 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -583,6 +583,30 @@ static const struct panel_desc avic_tm070ddh03 = { }, }; +static const struct drm_display_mode chunghwa_claa070wp03xg_mode = { + .clock = 66770, + .hdisplay = 800, + .hsync_start = 800 + 49, + .hsync_end = 800 + 49 + 33, + .htotal = 800 + 49 + 33 + 17, + .vdisplay = 1280, + .vsync_start = 1280 + 1, + .vsync_end = 1280 + 1 + 7, + .vtotal = 1280 + 1 + 7 + 15, + .vrefresh = 60, + .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC, +}; + +static const struct panel_desc chunghwa_claa070wp03xg = { + .modes = &chunghwa_claa070wp03xg_mode, + .num_modes = 1, + .bpc = 6, + .size = { + .width = 94, + .height = 150, + }, +}; + static const struct drm_display_mode chunghwa_claa101wa01a_mode = { .clock = 72070, .hdisplay = 1366, @@ -1544,6 +1568,9 @@ static const struct of_device_id platform_of_match[] = { .compatible = "avic,tm070ddh03", .data = &avic_tm070ddh03, }, { + .compatible = "chunghwa,claa070wp03xg", + .data = &chunghwa_claa070wp03xg, + }, { .compatible = "chunghwa,claa101wa01a", .data = &chunghwa_claa101wa01a }, {
The Chunghwa CLAA070WP03XG is a 7" 1280x800 panel, which can be supported by the simple panel driver. Signed-off-by: Randy Li <ayaka@soulik.info> --- .../display/panel/chunghwa,claa070wp03xg.txt | 7 ++++++ drivers/gpu/drm/panel/panel-simple.c | 27 ++++++++++++++++++++++ 2 files changed, 34 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt