| Message ID | 1474994615-29553-3-git-send-email-jack@suse.cz (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e568df6 |
| Headers | show |
On Tue, Sep 27, 2016 at 06:43:31PM +0200, Jan Kara wrote: > So far we did not return BH_New buffers from ext2_get_blocks() when we > allocated and zeroed-out a block for DAX inode to avoid racy zeroing in > DAX code. This zeroing is gone these days so we can remove the > workaround. > > Signed-off-by: Jan Kara <jack@suse.cz> Looks fine: Reviewed-by: Christoph Hellwig <hch@lst.de>
diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c index f6312c153731..ac8edbd4af74 100644 --- a/fs/ext2/inode.c +++ b/fs/ext2/inode.c @@ -754,9 +754,8 @@ static int ext2_get_blocks(struct inode *inode, mutex_unlock(&ei->truncate_mutex); goto cleanup; } - } else { - *new = true; } + *new = true; ext2_splice_branch(inode, iblock, partial, indirect_blks, count); mutex_unlock(&ei->truncate_mutex);
So far we did not return BH_New buffers from ext2_get_blocks() when we allocated and zeroed-out a block for DAX inode to avoid racy zeroing in DAX code. This zeroing is gone these days so we can remove the workaround. Signed-off-by: Jan Kara <jack@suse.cz> --- fs/ext2/inode.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)