| Message ID | 06ea14939405c3eb0fb9be655d26ee564a04a53d.1475571575.git.mylene.josserand@free-electrons.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Oct 04, 2016 at 11:46:21AM +0200, Mylène Josserand wrote: > +* Allwinner A23/A33 Analog Codec > + > +This codec must be handled as a PRCM subnode. What does this mean - how does one handle something as a "PRCM subnode"? Please use subject lines matching the style for the subsystem. This makes it easier for people to identify relevant patches.
Hi, On Tue, Oct 04, 2016 at 11:46:21AM +0200, Mylène Josserand wrote: > Add the documentation for dt-binding of the analog audiocodec > driver for SUN8I SoC. > > Signed-off-by: Mylène Josserand <mylene.josserand@free-electrons.com> > --- > .../devicetree/bindings/sound/sun8i-codec-analog.txt | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/sun8i-codec-analog.txt > > diff --git a/Documentation/devicetree/bindings/sound/sun8i-codec-analog.txt b/Documentation/devicetree/bindings/sound/sun8i-codec-analog.txt > new file mode 100644 > index 0000000..a03ec20 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/sun8i-codec-analog.txt > @@ -0,0 +1,20 @@ > +* Allwinner A23/A33 Analog Codec > + > +This codec must be handled as a PRCM subnode. Like Mark was saying, you should probably reference the sun6i-prcm.txt binding here > +Required properties: > +- compatible: must be either "allwinner,sun8i-codec-analog" Our compatible prefix is <family>-<soc>, and using the older SoC that introduced that block. In this case, that would be sun6i-a31, I think? Thanks, Maxime
On Wed, Oct 5, 2016 at 12:24 AM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > Hi, > > On Tue, Oct 04, 2016 at 11:46:21AM +0200, Mylène Josserand wrote: >> Add the documentation for dt-binding of the analog audiocodec >> driver for SUN8I SoC. >> >> Signed-off-by: Mylène Josserand <mylene.josserand@free-electrons.com> >> --- >> .../devicetree/bindings/sound/sun8i-codec-analog.txt | 20 ++++++++++++++++++++ >> 1 file changed, 20 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/sound/sun8i-codec-analog.txt >> >> diff --git a/Documentation/devicetree/bindings/sound/sun8i-codec-analog.txt b/Documentation/devicetree/bindings/sound/sun8i-codec-analog.txt >> new file mode 100644 >> index 0000000..a03ec20 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/sound/sun8i-codec-analog.txt >> @@ -0,0 +1,20 @@ >> +* Allwinner A23/A33 Analog Codec >> + >> +This codec must be handled as a PRCM subnode. > > Like Mark was saying, you should probably reference the sun6i-prcm.txt > binding here > >> +Required properties: >> +- compatible: must be either "allwinner,sun8i-codec-analog" > > Our compatible prefix is <family>-<soc>, and using the older SoC that > introduced that block. > > In this case, that would be sun6i-a31, I think? sun6i-a31s actually, but a31s has extra line out controls, so the right one would be sun8i-a23. Both are listed in my original driver. ChenYu > > Thanks, > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com
Hello, On 05/10/2016 04:59, Chen-Yu Tsai wrote: > On Wed, Oct 5, 2016 at 12:24 AM, Maxime Ripard > <maxime.ripard@free-electrons.com> wrote: >> Hi, >> >> On Tue, Oct 04, 2016 at 11:46:21AM +0200, Mylène Josserand wrote: >>> Add the documentation for dt-binding of the analog audiocodec >>> driver for SUN8I SoC. >>> >>> Signed-off-by: Mylène Josserand <mylene.josserand@free-electrons.com> >>> --- >>> .../devicetree/bindings/sound/sun8i-codec-analog.txt | 20 ++++++++++++++++++++ >>> 1 file changed, 20 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/sound/sun8i-codec-analog.txt >>> >>> diff --git a/Documentation/devicetree/bindings/sound/sun8i-codec-analog.txt b/Documentation/devicetree/bindings/sound/sun8i-codec-analog.txt >>> new file mode 100644 >>> index 0000000..a03ec20 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/sound/sun8i-codec-analog.txt >>> @@ -0,0 +1,20 @@ >>> +* Allwinner A23/A33 Analog Codec >>> + >>> +This codec must be handled as a PRCM subnode. >> >> Like Mark was saying, you should probably reference the sun6i-prcm.txt >> binding here Okay, I will explain more how it works. >> >>> +Required properties: >>> +- compatible: must be either "allwinner,sun8i-codec-analog" >> >> Our compatible prefix is <family>-<soc>, and using the older SoC that >> introduced that block. >> >> In this case, that would be sun6i-a31, I think? > > sun6i-a31s actually, but a31s has extra line out controls, > so the right one would be sun8i-a23. Both are listed in my > original driver. It is noted. Thanks!
diff --git a/Documentation/devicetree/bindings/sound/sun8i-codec-analog.txt b/Documentation/devicetree/bindings/sound/sun8i-codec-analog.txt new file mode 100644 index 0000000..a03ec20 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/sun8i-codec-analog.txt @@ -0,0 +1,20 @@ +* Allwinner A23/A33 Analog Codec + +This codec must be handled as a PRCM subnode. + +Required properties: +- compatible: must be either "allwinner,sun8i-codec-analog" +- interrupts: must contain the codec interrupt +- clocks: a list of phandle + clock-specifer pairs, one for each entry + in clock-names. +- clock-names: should contain followings: + - "apb": the parent APB clock for this controller + - "codec": the parent module clock + +Example, in your prcm subnode: +codec_analog: codec_analog { + compatible = "allwinner,sun8i-codec-analog"; + interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&ccu CLK_BUS_CODEC>, <&ccu CLK_AC_DIG>; + clock-names = "apb", "codec"; +};
Add the documentation for dt-binding of the analog audiocodec driver for SUN8I SoC. Signed-off-by: Mylène Josserand <mylene.josserand@free-electrons.com> --- .../devicetree/bindings/sound/sun8i-codec-analog.txt | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/sun8i-codec-analog.txt