| Message ID | 1476455702-21748-3-git-send-email-javier@osg.samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 14/10/2016 16:35, Javier Martinez Canillas wrote: > If the driver is built as a module, autoload won't work because the module > alias information is not filled. So user-space can't match the registered > device with the corresponding module. > > Export the module alias information using the MODULE_DEVICE_TABLE() macro. > > Before this patch: > > $ modinfo drivers/thermal/tango_thermal.ko | grep alias > $ > > After this patch: > > $ modinfo drivers/thermal/tango_thermal.ko | grep alias > alias: of:N*T*Csigma,smp8758-thermalC* > alias: of:N*T*Csigma,smp8758-thermal > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> > --- > > drivers/thermal/tango_thermal.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/thermal/tango_thermal.c b/drivers/thermal/tango_thermal.c > index 201304aeafeb..4e67795cb6ce 100644 > --- a/drivers/thermal/tango_thermal.c > +++ b/drivers/thermal/tango_thermal.c > @@ -107,6 +107,7 @@ static const struct of_device_id tango_sensor_ids[] = { > }, > { /* sentinel */ } > }; > +MODULE_DEVICE_TABLE(of, tango_sensor_ids); Thanks for fixing it :-) Acked-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com> Regards.
diff --git a/drivers/thermal/tango_thermal.c b/drivers/thermal/tango_thermal.c index 201304aeafeb..4e67795cb6ce 100644 --- a/drivers/thermal/tango_thermal.c +++ b/drivers/thermal/tango_thermal.c @@ -107,6 +107,7 @@ static const struct of_device_id tango_sensor_ids[] = { }, { /* sentinel */ } }; +MODULE_DEVICE_TABLE(of, tango_sensor_ids); static struct platform_driver tango_thermal_driver = { .probe = tango_thermal_probe,
If the driver is built as a module, autoload won't work because the module alias information is not filled. So user-space can't match the registered device with the corresponding module. Export the module alias information using the MODULE_DEVICE_TABLE() macro. Before this patch: $ modinfo drivers/thermal/tango_thermal.ko | grep alias $ After this patch: $ modinfo drivers/thermal/tango_thermal.ko | grep alias alias: of:N*T*Csigma,smp8758-thermalC* alias: of:N*T*Csigma,smp8758-thermal Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> --- drivers/thermal/tango_thermal.c | 1 + 1 file changed, 1 insertion(+)