| Message ID | 1476297352-7812-2-git-send-email-scott.branden@broadcom.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Oct 12, 2016 at 11:35:51AM -0700, Scott Branden wrote: > Adds brcm,sdhci-iproc compat string to DT bindings document for > the iProc SDHCI driver. > > Signed-off-by: Anup Patel <anup.patel@broadcom.com> > Signed-off-by: Scott Branden <scott.branden@broadcom.com> > --- > Documentation/devicetree/bindings/mmc/brcm,sdhci-iproc.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/mmc/brcm,sdhci-iproc.txt b/Documentation/devicetree/bindings/mmc/brcm,sdhci-iproc.txt > index be56d2b..aa58b94 100644 > --- a/Documentation/devicetree/bindings/mmc/brcm,sdhci-iproc.txt > +++ b/Documentation/devicetree/bindings/mmc/brcm,sdhci-iproc.txt > @@ -7,6 +7,7 @@ Required properties: > - compatible : Should be one of the following > "brcm,bcm2835-sdhci" > "brcm,sdhci-iproc-cygnus" > + "brcm,sdhci-iproc" Seems kind of generic. SoC specific compatible strings please.
Hi Rob, On 16-10-18 06:16 AM, Rob Herring wrote: > On Wed, Oct 12, 2016 at 11:35:51AM -0700, Scott Branden wrote: >> Adds brcm,sdhci-iproc compat string to DT bindings document for >> the iProc SDHCI driver. >> >> Signed-off-by: Anup Patel <anup.patel@broadcom.com> >> Signed-off-by: Scott Branden <scott.branden@broadcom.com> >> --- >> Documentation/devicetree/bindings/mmc/brcm,sdhci-iproc.txt | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/mmc/brcm,sdhci-iproc.txt b/Documentation/devicetree/bindings/mmc/brcm,sdhci-iproc.txt >> index be56d2b..aa58b94 100644 >> --- a/Documentation/devicetree/bindings/mmc/brcm,sdhci-iproc.txt >> +++ b/Documentation/devicetree/bindings/mmc/brcm,sdhci-iproc.txt >> @@ -7,6 +7,7 @@ Required properties: >> - compatible : Should be one of the following >> "brcm,bcm2835-sdhci" >> "brcm,sdhci-iproc-cygnus" >> + "brcm,sdhci-iproc" > > Seems kind of generic. SoC specific compatible strings please. > The compatibility string is generic on purpose as it is not intended to be SoC specific but work on all new iproc SoCs that have the proper fixes in place for this block (unlike bcm2835 and cygnus class devices which can only do 32-bit accesses). I could call it brcm,sdhci-iproc-v2 if that is better or leave it as is. Please let me know your preferences. Regards, Scott
Hi Rob, On 16-10-18 01:08 PM, Scott Branden wrote: > Hi Rob, > > On 16-10-18 06:16 AM, Rob Herring wrote: >> On Wed, Oct 12, 2016 at 11:35:51AM -0700, Scott Branden wrote: >>> Adds brcm,sdhci-iproc compat string to DT bindings document for >>> the iProc SDHCI driver. >>> >>> Signed-off-by: Anup Patel <anup.patel@broadcom.com> >>> Signed-off-by: Scott Branden <scott.branden@broadcom.com> >>> --- >>> Documentation/devicetree/bindings/mmc/brcm,sdhci-iproc.txt | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git >>> a/Documentation/devicetree/bindings/mmc/brcm,sdhci-iproc.txt >>> b/Documentation/devicetree/bindings/mmc/brcm,sdhci-iproc.txt >>> index be56d2b..aa58b94 100644 >>> --- a/Documentation/devicetree/bindings/mmc/brcm,sdhci-iproc.txt >>> +++ b/Documentation/devicetree/bindings/mmc/brcm,sdhci-iproc.txt >>> @@ -7,6 +7,7 @@ Required properties: >>> - compatible : Should be one of the following >>> "brcm,bcm2835-sdhci" >>> "brcm,sdhci-iproc-cygnus" >>> + "brcm,sdhci-iproc" >> >> Seems kind of generic. SoC specific compatible strings please. >> > The compatibility string is generic on purpose as it is not intended to > be SoC specific but work on all new iproc SoCs that have the proper > fixes in place for this block (unlike bcm2835 and cygnus class devices > which can only do 32-bit accesses). I could call it brcm,sdhci-iproc-v2 > if that is better or leave it as is. Please let me know your preferences. > I just sent out v2 of the patch with additional details in the device tree bindings document. Please let me know if this covers your concerns. The SDHCI controller binding is not SoC specific and is used in multiple SoCs going forward with the same binding. > Regards, > Scott
diff --git a/Documentation/devicetree/bindings/mmc/brcm,sdhci-iproc.txt b/Documentation/devicetree/bindings/mmc/brcm,sdhci-iproc.txt index be56d2b..aa58b94 100644 --- a/Documentation/devicetree/bindings/mmc/brcm,sdhci-iproc.txt +++ b/Documentation/devicetree/bindings/mmc/brcm,sdhci-iproc.txt @@ -7,6 +7,7 @@ Required properties: - compatible : Should be one of the following "brcm,bcm2835-sdhci" "brcm,sdhci-iproc-cygnus" + "brcm,sdhci-iproc" - clocks : The clock feeding the SDHCI controller.