| Message ID | 1476733877-20275-1-git-send-email-javier@osg.samsung.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
On 10/17/2016 09:51 PM, Javier Martinez Canillas wrote: > If the driver is built as a module, autoload won't work because the module > alias information is not filled. So user-space can't match the registered > device with the corresponding module. > > Export the module alias information using the MODULE_DEVICE_TABLE() macro. > > Before this patch: > > $ modinfo drivers/char/hw_random/meson-rng.ko | grep alias > alias: platform:meson-rng > > After this patch: > > $ modinfo drivers/char/hw_random/meson-rng.ko | grep alias > alias: platform:meson-rng > alias: of:N*T*Camlogic,meson-rngC* > alias: of:N*T*Camlogic,meson-rng > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> > > --- > > Changes in v2: > - Remove unrelated changes added by mistake. Suggested by Jason Gunthorpe. > > drivers/char/hw_random/meson-rng.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/char/hw_random/meson-rng.c b/drivers/char/hw_random/meson-rng.c > index 58bef39f7286..51864a509be7 100644 > --- a/drivers/char/hw_random/meson-rng.c > +++ b/drivers/char/hw_random/meson-rng.c > @@ -110,6 +110,7 @@ static const struct of_device_id meson_rng_of_match[] = { > { .compatible = "amlogic,meson-rng", }, > {}, > }; > +MODULE_DEVICE_TABLE(of, meson_rng_of_match); > > static struct platform_driver meson_rng_driver = { > .probe = meson_rng_probe, > Acked-by: Neil Armstrong <narmstrong@baylibre.com>
On Mon, Oct 17, 2016 at 04:51:17PM -0300, Javier Martinez Canillas wrote: > If the driver is built as a module, autoload won't work because the module > alias information is not filled. So user-space can't match the registered > device with the corresponding module. > > Export the module alias information using the MODULE_DEVICE_TABLE() macro. > > Before this patch: > > $ modinfo drivers/char/hw_random/meson-rng.ko | grep alias > alias: platform:meson-rng > > After this patch: > > $ modinfo drivers/char/hw_random/meson-rng.ko | grep alias > alias: platform:meson-rng > alias: of:N*T*Camlogic,meson-rngC* > alias: of:N*T*Camlogic,meson-rng > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> Patch applied. Thanks.
diff --git a/drivers/char/hw_random/meson-rng.c b/drivers/char/hw_random/meson-rng.c index 58bef39f7286..51864a509be7 100644 --- a/drivers/char/hw_random/meson-rng.c +++ b/drivers/char/hw_random/meson-rng.c @@ -110,6 +110,7 @@ static const struct of_device_id meson_rng_of_match[] = { { .compatible = "amlogic,meson-rng", }, {}, }; +MODULE_DEVICE_TABLE(of, meson_rng_of_match); static struct platform_driver meson_rng_driver = { .probe = meson_rng_probe,
If the driver is built as a module, autoload won't work because the module alias information is not filled. So user-space can't match the registered device with the corresponding module. Export the module alias information using the MODULE_DEVICE_TABLE() macro. Before this patch: $ modinfo drivers/char/hw_random/meson-rng.ko | grep alias alias: platform:meson-rng After this patch: $ modinfo drivers/char/hw_random/meson-rng.ko | grep alias alias: platform:meson-rng alias: of:N*T*Camlogic,meson-rngC* alias: of:N*T*Camlogic,meson-rng Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> --- Changes in v2: - Remove unrelated changes added by mistake. Suggested by Jason Gunthorpe. drivers/char/hw_random/meson-rng.c | 1 + 1 file changed, 1 insertion(+)