diff mbox

[libdrm,2/2] Silence runtime complaints on platform devices

Message ID 20161021171240.6972-2-eric@anholt.net (mailing list archive)
State New, archived
Headers show

Commit Message

Eric Anholt Oct. 21, 2016, 5:12 p.m. UTC 
glxgears was spamming this 12 times at startup because of Mesa's
probing of the DRM device code, which doesn't support platform
devices.

Signed-off-by: Eric Anholt <eric@anholt.net>
---
 xf86drm.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Alex Deucher Oct. 21, 2016, 5:32 p.m. UTC | #1 
On Fri, Oct 21, 2016 at 1:12 PM, Eric Anholt <eric@anholt.net> wrote:
> glxgears was spamming this 12 times at startup because of Mesa's
> probing of the DRM device code, which doesn't support platform
> devices.
>
> Signed-off-by: Eric Anholt <eric@anholt.net>

Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

> ---
>  xf86drm.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/xf86drm.c b/xf86drm.c
> index 9b52889e4cef..52add5e441d7 100644
> --- a/xf86drm.c
> +++ b/xf86drm.c
> @@ -3149,7 +3149,6 @@ int drmGetDevice(int fd, drmDevicePtr *device)
>
>              break;
>          default:
> -            fprintf(stderr, "The subsystem type is not supported yet\n");
>              continue;
>          }
>
> @@ -3259,7 +3258,6 @@ int drmGetDevices(drmDevicePtr devices[], int max_devices)
>
>              break;
>          default:
> -            fprintf(stderr, "The subsystem type is not supported yet\n");
>              continue;
>          }
>
> --
> 2.9.3
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
Emil Velikov Oct. 24, 2016, 11:11 a.m. UTC | #2 
On 21 October 2016 at 18:12, Eric Anholt <eric@anholt.net> wrote:
> glxgears was spamming this 12 times at startup because of Mesa's
> probing of the DRM device code, which doesn't support platform
> devices.
>
Better option is to add support for platform devices. Can we get
anyone interested in that ?
If we drop (the annoying) printf people will just ignore/forget about
it, and things will fall through the cracks - similar to the 5+ pokes
(at various people) to add support.

On the cool side - it will allow you to use the DRI_PRIME/driconf's
device_id=libudev_path_id_tag to manage the devices on your system.

Thanks
Emil
Eric Anholt Oct. 24, 2016, 4:35 p.m. UTC | #3 
Emil Velikov <emil.l.velikov@gmail.com> writes:

> On 21 October 2016 at 18:12, Eric Anholt <eric@anholt.net> wrote:
>> glxgears was spamming this 12 times at startup because of Mesa's
>> probing of the DRM device code, which doesn't support platform
>> devices.
>>
> Better option is to add support for platform devices. Can we get
> anyone interested in that ?

I agree it would be good but it certainly isn't remotely near the top of
my todo list.  I'm just fixing up regressions.
diff mbox

Patch

diff --git a/xf86drm.c b/xf86drm.c
index 9b52889e4cef..52add5e441d7 100644
--- a/xf86drm.c
+++ b/xf86drm.c
@@ -3149,7 +3149,6 @@  int drmGetDevice(int fd, drmDevicePtr *device)
 
             break;
         default:
-            fprintf(stderr, "The subsystem type is not supported yet\n");
             continue;
         }
 
@@ -3259,7 +3258,6 @@  int drmGetDevices(drmDevicePtr devices[], int max_devices)
 
             break;
         default:
-            fprintf(stderr, "The subsystem type is not supported yet\n");
             continue;
         }