diff mbox

[1/2] fscrypto: Fix log string in do_crypto()

Message ID 1476824089-6841-2-git-send-email-richard@nod.at (mailing list archive)
State New, archived
Headers show

Commit Message

Richard Weinberger Oct. 18, 2016, 8:54 p.m. UTC 
The operations supports both encryption and decryption.

Signed-off-by: Richard Weinberger <richard@nod.at>
---
 fs/crypto/crypto.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Eric Biggers Oct. 21, 2016, 8:02 p.m. UTC | #1 
On Tue, Oct 18, 2016 at 10:54:48PM +0200, Richard Weinberger wrote:
> The operations supports both encryption and decryption.
> 
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---
>  fs/crypto/crypto.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/crypto/crypto.c b/fs/crypto/crypto.c
> index 61057b7dbddb..1637a0450b9f 100644
> --- a/fs/crypto/crypto.c
> +++ b/fs/crypto/crypto.c
> @@ -194,8 +194,9 @@ static int do_page_crypto(struct inode *inode,
>  	skcipher_request_free(req);
>  	if (res) {
>  		printk_ratelimited(KERN_ERR
> -			"%s: crypto_skcipher_encrypt() returned %d\n",
> -			__func__, res);
> +			"%s: crypto_skcipher_%scrypt() returned %d, flags %#x\n",
> +			__func__, rw == FS_DECRYPT ? "de" : "en", res,
> +			crypto_skcipher_get_flags(tfm));
>  		return res;
>  	}
>  	return 0;
> -- 
> 2.7.3
> 

Looks fine.

Reviewed-by: Eric Biggers <ebiggers@google.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/fs/crypto/crypto.c b/fs/crypto/crypto.c
index 61057b7dbddb..1637a0450b9f 100644
--- a/fs/crypto/crypto.c
+++ b/fs/crypto/crypto.c
@@ -194,8 +194,9 @@  static int do_page_crypto(struct inode *inode,
 	skcipher_request_free(req);
 	if (res) {
 		printk_ratelimited(KERN_ERR
-			"%s: crypto_skcipher_encrypt() returned %d\n",
-			__func__, res);
+			"%s: crypto_skcipher_%scrypt() returned %d, flags %#x\n",
+			__func__, rw == FS_DECRYPT ? "de" : "en", res,
+			crypto_skcipher_get_flags(tfm));
 		return res;
 	}
 	return 0;