| Message ID | w3psjr3yauo.wl%kuninori.morimoto.gx@renesas.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
On Tue, Jun 21, 2011 at 03:09:19PM +0900, Kuninori Morimoto wrote: > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > --- > drivers/usb/renesas_usbhs/mod_gadget.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > Does this have any dependencies? What about platforms that don't support dmaengine? -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Dear Paul Thank you for your check > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > --- > > drivers/usb/renesas_usbhs/mod_gadget.c | 4 ++-- > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > Does this have any dependencies? What about platforms that don't support > dmaengine? renesas_usbhs driver will use PIO mode if platforms doesn't have/support dmaengine more explain or rename needed ? Best regards -- Kuninori Morimoto -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jun 21, 2011 at 07:34:17PM +0900, Kuninori Morimoto wrote: > > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > > --- > > > drivers/usb/renesas_usbhs/mod_gadget.c | 4 ++-- > > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > > > Does this have any dependencies? What about platforms that don't support > > dmaengine? > > renesas_usbhs driver will use PIO mode if platforms doesn't have/support > dmaengine > > more explain or rename needed ? > No, that's fine. It wasn't immediately obvious that the PIO fallback and overriding of the handler was being done in the DMA routines. Looks good to me, I'll let Greg pick it up for usb-next. -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/usb/renesas_usbhs/mod_gadget.c b/drivers/usb/renesas_usbhs/mod_gadget.c index ce35319..da76634 100644 --- a/drivers/usb/renesas_usbhs/mod_gadget.c +++ b/drivers/usb/renesas_usbhs/mod_gadget.c @@ -485,9 +485,9 @@ static int usbhsg_ep_enable(struct usb_ep *ep, pipe->mod_private = uep; if (usb_endpoint_dir_in(desc)) - uep->handler = &usbhs_fifo_pio_push_handler; + uep->handler = &usbhs_fifo_dma_push_handler; else - uep->handler = &usbhs_fifo_pio_pop_handler; + uep->handler = &usbhs_fifo_dma_pop_handler; ret = 0; }
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> --- drivers/usb/renesas_usbhs/mod_gadget.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)