diff mbox

[COLO-Frame,(Base),v22,17/17] configure: Support enable/disable COLO feature

Message ID 1477496530-9624-18-git-send-email-zhang.zhanghailiang@huawei.com (mailing list archive)
State New, archived
Headers show

Commit Message

Zhanghailiang Oct. 26, 2016, 3:42 p.m. UTC 
configure --enable-colo/--disable-colo to switch COLO
support on/off.

COLO feature doesn't depend on any other external librariesis,
So here it is reasonable to enable COLO by default, to
avoid re-compile QEMU if users want to use this capability.

Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
Signed-off-by: Gonglei <arei.gonglei@huawei.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Amit Shah <amit.shah@redhat.com>
---
v22:
- Add Reviewed-by tag
v19:
- fix colo_supported() to return true
v11:
- Turn COLO on in default (Eric's suggestion)
---
 configure        | 11 +++++++++++
 migration/colo.c |  2 +-
 2 files changed, 12 insertions(+), 1 deletion(-)

Comments

Amit Shah Oct. 27, 2016, 4:21 a.m. UTC | #1 
On (Wed) 26 Oct 2016 [23:42:10], zhanghailiang wrote:
> configure --enable-colo/--disable-colo to switch COLO
> support on/off.
> 
> COLO feature doesn't depend on any other external librariesis,

typo: libraries


		Amit
Zhanghailiang Oct. 27, 2016, 6:13 a.m. UTC | #2 
On 2016/10/27 12:21, Amit Shah wrote:
> On (Wed) 26 Oct 2016 [23:42:10], zhanghailiang wrote:
>> configure --enable-colo/--disable-colo to switch COLO
>> support on/off.
>>
>> COLO feature doesn't depend on any other external librariesis,
>
> typo: libraries
>

Will fix in next version, thanks :)

>
> 		Amit
>
> .
>
diff mbox

Patch

diff --git a/configure b/configure
index d3dafcb..8e3b760 100755
--- a/configure
+++ b/configure
@@ -230,6 +230,7 @@  vhost_net="no"
 vhost_scsi="no"
 vhost_vsock="no"
 kvm="no"
+colo="yes"
 rdma=""
 gprof="no"
 debug_tcg="no"
@@ -918,6 +919,10 @@  for opt do
   ;;
   --enable-kvm) kvm="yes"
   ;;
+  --disable-colo) colo="no"
+  ;;
+  --enable-colo) colo="yes"
+  ;;
   --disable-tcg-interpreter) tcg_interpreter="no"
   ;;
   --enable-tcg-interpreter) tcg_interpreter="yes"
@@ -1363,6 +1368,7 @@  disabled with --disable-FEATURE, default is enabled if available:
   fdt             fdt device tree
   bluez           bluez stack connectivity
   kvm             KVM acceleration support
+  colo            COarse-grain LOck-stepping VM for Non-stop Service
   rdma            RDMA-based migration support
   vde             support for vde network
   netmap          support for netmap network
@@ -4941,6 +4947,7 @@  echo "Linux AIO support $linux_aio"
 echo "ATTR/XATTR support $attr"
 echo "Install blobs     $blobs"
 echo "KVM support       $kvm"
+echo "COLO support      $colo"
 echo "RDMA support      $rdma"
 echo "TCG interpreter   $tcg_interpreter"
 echo "fdt support       $fdt"
@@ -5568,6 +5575,10 @@  if have_backend "syslog"; then
 fi
 echo "CONFIG_TRACE_FILE=$trace_file" >> $config_host_mak
 
+if test "$colo" = "yes"; then
+  echo "CONFIG_COLO=y" >> $config_host_mak
+fi
+
 if test "$rdma" = "yes" ; then
   echo "CONFIG_RDMA=y" >> $config_host_mak
 fi
diff --git a/migration/colo.c b/migration/colo.c
index 31664e0..a39cd99 100644
--- a/migration/colo.c
+++ b/migration/colo.c
@@ -24,7 +24,7 @@ 
 
 bool colo_supported(void)
 {
-    return false;
+    return true;
 }
 
 bool migration_in_colo_state(void)