| Message ID | 1477576531-29723-1-git-send-email-ilyan@dev.mellanox.co.il (mailing list archive) |
|---|---|
| State | Rejected |
| Delegated to: | Hal Rosenstock |
| Headers | show |
On Thu, Oct 27, 2016 at 04:55:31PM +0300, Ilya Nelkenbaum wrote: > From: Ilya Nelkenbaum <ilyan@mellanox.com> > > Signed-off-by: Ilya Nelkenbaum <ilyan@mellanox.com> > --- > ibsim/Makefile | 2 ++ > 1 file changed, 2 insertions(+) Against which tree did you base your code? Thanks. > > diff --git a/ibsim/Makefile b/ibsim/Makefile > index 5d1ac62..ad94651 100644 > --- a/ibsim/Makefile > +++ b/ibsim/Makefile > @@ -1,5 +1,7 @@ > progs:=ibsim > > +ibsim_LDFLAGS = "-Wl,-rpath,\$$ORIGIN/../lib" > + > -include ../defs.mk > > all: $(progs) > -- > 1.8.3.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
On 10/27/2016 10:38 AM, Leon Romanovsky wrote: > On Thu, Oct 27, 2016 at 04:55:31PM +0300, Ilya Nelkenbaum wrote: >> From: Ilya Nelkenbaum <ilyan@mellanox.com> >> >> Signed-off-by: Ilya Nelkenbaum <ilyan@mellanox.com> >> --- >> ibsim/Makefile | 2 ++ >> 1 file changed, 2 insertions(+) > > Against which tree did you base your code? Upstream ibsim git repo is git://git.openfabrics.org/~halr/ibsim.git so I assume Ilya's patch is against this repo. -- Hal > > Thanks. > >> >> diff --git a/ibsim/Makefile b/ibsim/Makefile >> index 5d1ac62..ad94651 100644 >> --- a/ibsim/Makefile >> +++ b/ibsim/Makefile >> @@ -1,5 +1,7 @@ >> progs:=ibsim >> >> +ibsim_LDFLAGS = "-Wl,-rpath,\$$ORIGIN/../lib" >> + >> -include ../defs.mk >> >> all: $(progs) >> -- >> 1.8.3.1 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Oct 27, 2016 at 04:55:31PM +0300, Ilya Nelkenbaum wrote:
> From: Ilya Nelkenbaum <ilyan@mellanox.com>
One should never open code rpath like this, it makes distros angry.
Use libtool or whatever.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/ibsim/Makefile b/ibsim/Makefile index 5d1ac62..ad94651 100644 --- a/ibsim/Makefile +++ b/ibsim/Makefile @@ -1,5 +1,7 @@ progs:=ibsim +ibsim_LDFLAGS = "-Wl,-rpath,\$$ORIGIN/../lib" + -include ../defs.mk all: $(progs)