diff mbox

[16/60] block: pktcdvd: comment on direct access to bvec table

Message ID 1477728600-12938-17-git-send-email-tom.leiming@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Ming Lei Oct. 29, 2016, 8:08 a.m. UTC
Signed-off-by: Ming Lei <tom.leiming@gmail.com>
---
 drivers/block/pktcdvd.c | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Christoph Hellwig Oct. 31, 2016, 3:33 p.m. UTC | #1
Please pick up my "pktcdvd: don't scribble over the bvec array"
patch instead of the pktcdvd patches in this series.
--
To unsubscribe from this list: send the line "unsubscribe linux-block" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Ming Lei Oct. 31, 2016, 11:08 p.m. UTC | #2
On Mon, Oct 31, 2016 at 11:33 PM, Christoph Hellwig <hch@infradead.org> wrote:
> Please pick up my "pktcdvd: don't scribble over the bvec array"
> patch instead of the pktcdvd patches in this series.

OK.

Thanks,
Ming Lei
--
To unsubscribe from this list: send the line "unsubscribe linux-block" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c
index 90fa4ac149db..817d2cc17d01 100644
--- a/drivers/block/pktcdvd.c
+++ b/drivers/block/pktcdvd.c
@@ -1298,6 +1298,11 @@  static int pkt_handle_queue(struct pktcdvd_device *pd)
 static void pkt_start_write(struct pktcdvd_device *pd, struct packet_data *pkt)
 {
 	int f;
+
+	/*
+	 * Need to fix this usage for supporting multipage bvecs,
+	 * because the table can be changed in pkt_make_local_copy().
+	 */
 	struct bio_vec *bvec = pkt->w_bio->bi_io_vec;
 
 	bio_reset(pkt->w_bio);