| Message ID | 1478030682-27012-3-git-send-email-jon.mason@broadcom.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
> +- enet-phy-lane-swap: If set, indicates the PHY device requires swapping the > + TX/RX lanes to function properly. Is 'requires' the right word here? The PHY performs the actual swap of the Tx/Rx lanes. Andrew
On Tue, Nov 01, 2016 at 09:48:26PM +0100, Andrew Lunn wrote: > > +- enet-phy-lane-swap: If set, indicates the PHY device requires swapping the > > + TX/RX lanes to function properly. > > Is 'requires' the right word here? The PHY performs the actual swap of > the Tx/Rx lanes. What I'm trying to say here is that without the lane swapping, the PHY will not function properly. Thus, those PHYs require this parameter to work. I am open to suggestions to reword the sentence to make it clearer. Thanks, Jon > > Andrew
On 16-11-01 01:59 PM, Jon Mason wrote: > On Tue, Nov 01, 2016 at 09:48:26PM +0100, Andrew Lunn wrote: >>> +- enet-phy-lane-swap: If set, indicates the PHY device requires swapping the >>> + TX/RX lanes to function properly. >> >> Is 'requires' the right word here? The PHY performs the actual swap of >> the Tx/Rx lanes. > > What I'm trying to say here is that without the lane swapping, the PHY > will not function properly. Thus, those PHYs require this parameter > to work. I am open to suggestions to reword the sentence to make it > clearer. If set, indicates the PHY will swap the TX/RX lanes to compensate for the board being designed with the lanes swapped. > > Thanks, > Jon > >> >> Andrew
> If set, indicates the PHY will swap the TX/RX lanes to compensate > for the board being designed with the lanes swapped. Thanks, much better. Andrew
diff --git a/Documentation/devicetree/bindings/net/phy.txt b/Documentation/devicetree/bindings/net/phy.txt index bc1c3c8..3dce607 100644 --- a/Documentation/devicetree/bindings/net/phy.txt +++ b/Documentation/devicetree/bindings/net/phy.txt @@ -35,6 +35,9 @@ Optional Properties: - broken-turn-around: If set, indicates the PHY device does not correctly release the turn around line low at the end of a MDIO transaction. +- enet-phy-lane-swap: If set, indicates the PHY device requires swapping the + TX/RX lanes to function properly. + Example: ethernet-phy@0 {
Add the documentation for PHY lane swapping. This is a boolean entry to notify the phy device drivers that the TX/RX lanes need to be swapped. Signed-off-by: Jon Mason <jon.mason@broadcom.com> --- Documentation/devicetree/bindings/net/phy.txt | 3 +++ 1 file changed, 3 insertions(+)