| Message ID | 20161103062135.10697-11-jh80.chung@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Nov 03, 2016 at 03:21:32PM +0900, Jaehoon Chung wrote: > In drivers/mmc/core/host.c, there is "max-frequency" property. > It should be same behavior. So Use the "max-frequency" instead of > "clock-freq-min-max". > > Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> > --- > arch/arm/boot/dts/exynos3250-artik5-eval.dts | 2 +- > arch/arm/boot/dts/exynos3250-artik5.dtsi | 2 +- > arch/arm/boot/dts/exynos3250-monk.dts | 2 +- > arch/arm/boot/dts/exynos3250-rinato.dts | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) This looks totally independent to rest of patches so it can be applied separately without any functional impact (except lack of minimum frequency). Is that correct? Best regards, Krzysztof
On 11/04/2016 03:41 AM, Krzysztof Kozlowski wrote: > On Thu, Nov 03, 2016 at 03:21:32PM +0900, Jaehoon Chung wrote: >> In drivers/mmc/core/host.c, there is "max-frequency" property. >> It should be same behavior. So Use the "max-frequency" instead of >> "clock-freq-min-max". >> >> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> >> --- >> arch/arm/boot/dts/exynos3250-artik5-eval.dts | 2 +- >> arch/arm/boot/dts/exynos3250-artik5.dtsi | 2 +- >> arch/arm/boot/dts/exynos3250-monk.dts | 2 +- >> arch/arm/boot/dts/exynos3250-rinato.dts | 2 +- >> 4 files changed, 4 insertions(+), 4 deletions(-) > > This looks totally independent to rest of patches so it can be applied > separately without any functional impact (except lack of minimum > frequency). Is that correct? You're right. I will split the patches. And will resend. Thanks! Best Regards, Jaehoon Chung > > Best regards, > Krzysztof > > > >
Hi Jaehoon, Am Freitag, 4. November 2016, 19:21:30 CET schrieb Jaehoon Chung: > On 11/04/2016 03:41 AM, Krzysztof Kozlowski wrote: > > On Thu, Nov 03, 2016 at 03:21:32PM +0900, Jaehoon Chung wrote: > >> In drivers/mmc/core/host.c, there is "max-frequency" property. > >> It should be same behavior. So Use the "max-frequency" instead of > >> "clock-freq-min-max". > >> > >> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> > >> --- > >> > >> arch/arm/boot/dts/exynos3250-artik5-eval.dts | 2 +- > >> arch/arm/boot/dts/exynos3250-artik5.dtsi | 2 +- > >> arch/arm/boot/dts/exynos3250-monk.dts | 2 +- > >> arch/arm/boot/dts/exynos3250-rinato.dts | 2 +- > >> 4 files changed, 4 insertions(+), 4 deletions(-) > > > > This looks totally independent to rest of patches so it can be applied > > separately without any functional impact (except lack of minimum > > frequency). Is that correct? > > You're right. I will split the patches. And will resend. > Thanks! I think what Krzysztof was asking was just if he can simply pick up this patch alone, as it does not require any of the previous changes. Same is true for the Rockchip patches I guess, so we could just take them individually into samsung/rockchip dts branches. Heiko
On Fri, Nov 04, 2016 at 12:19:49PM +0100, Heiko Stuebner wrote: > Hi Jaehoon, > > Am Freitag, 4. November 2016, 19:21:30 CET schrieb Jaehoon Chung: > > On 11/04/2016 03:41 AM, Krzysztof Kozlowski wrote: > > > On Thu, Nov 03, 2016 at 03:21:32PM +0900, Jaehoon Chung wrote: > > >> In drivers/mmc/core/host.c, there is "max-frequency" property. > > >> It should be same behavior. So Use the "max-frequency" instead of > > >> "clock-freq-min-max". > > >> > > >> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> > > >> --- > > >> > > >> arch/arm/boot/dts/exynos3250-artik5-eval.dts | 2 +- > > >> arch/arm/boot/dts/exynos3250-artik5.dtsi | 2 +- > > >> arch/arm/boot/dts/exynos3250-monk.dts | 2 +- > > >> arch/arm/boot/dts/exynos3250-rinato.dts | 2 +- > > >> 4 files changed, 4 insertions(+), 4 deletions(-) > > > > > > This looks totally independent to rest of patches so it can be applied > > > separately without any functional impact (except lack of minimum > > > frequency). Is that correct? > > > > You're right. I will split the patches. And will resend. > > Thanks! > > I think what Krzysztof was asking was just if he can simply pick up this patch > alone, as it does not require any of the previous changes. > > Same is true for the Rockchip patches I guess, so we could just take them > individually into samsung/rockchip dts branches. Yes, I wanted to get exactly this information. I couldn't find it in cover letter. Best regards, Krzysztof
On 11/05/2016 12:04 AM, Krzysztof Kozlowski wrote: > On Fri, Nov 04, 2016 at 12:19:49PM +0100, Heiko Stuebner wrote: >> Hi Jaehoon, >> >> Am Freitag, 4. November 2016, 19:21:30 CET schrieb Jaehoon Chung: >>> On 11/04/2016 03:41 AM, Krzysztof Kozlowski wrote: >>>> On Thu, Nov 03, 2016 at 03:21:32PM +0900, Jaehoon Chung wrote: >>>>> In drivers/mmc/core/host.c, there is "max-frequency" property. >>>>> It should be same behavior. So Use the "max-frequency" instead of >>>>> "clock-freq-min-max". >>>>> >>>>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> >>>>> --- >>>>> >>>>> arch/arm/boot/dts/exynos3250-artik5-eval.dts | 2 +- >>>>> arch/arm/boot/dts/exynos3250-artik5.dtsi | 2 +- >>>>> arch/arm/boot/dts/exynos3250-monk.dts | 2 +- >>>>> arch/arm/boot/dts/exynos3250-rinato.dts | 2 +- >>>>> 4 files changed, 4 insertions(+), 4 deletions(-) >>>> >>>> This looks totally independent to rest of patches so it can be applied >>>> separately without any functional impact (except lack of minimum >>>> frequency). Is that correct? >>> >>> You're right. I will split the patches. And will resend. >>> Thanks! >> >> I think what Krzysztof was asking was just if he can simply pick up this patch >> alone, as it does not require any of the previous changes. >> >> Same is true for the Rockchip patches I guess, so we could just take them >> individually into samsung/rockchip dts branches. > > Yes, I wanted to get exactly this information. I couldn't find it in > cover letter. In drivers/mmc/core/host.c, there already is "max-frequency" property. It's same functionality with "clock-freq-min-max". Minimum clock value can be fixed to 100K. because MMC core will check clock value from 400K to 100K. But max-frequency can be difference. If we can use "max-frequency" property, we don't need to use "clock-freq-min-max" property anymore. I will resend the deprecated property instead of removing "clock-freq-min-max". If you want to pick this, it's possible to pick. Then i will resend the patches without dt patches. Best Regards, Jaehoon Chung > > Best regards, > Krzysztof > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > >
On Mon, Nov 07, 2016 at 09:38:15AM +0900, Jaehoon Chung wrote: > On 11/05/2016 12:04 AM, Krzysztof Kozlowski wrote: > > On Fri, Nov 04, 2016 at 12:19:49PM +0100, Heiko Stuebner wrote: > >> Hi Jaehoon, > >> > >> Am Freitag, 4. November 2016, 19:21:30 CET schrieb Jaehoon Chung: > >>> On 11/04/2016 03:41 AM, Krzysztof Kozlowski wrote: > >>>> On Thu, Nov 03, 2016 at 03:21:32PM +0900, Jaehoon Chung wrote: > >>>>> In drivers/mmc/core/host.c, there is "max-frequency" property. > >>>>> It should be same behavior. So Use the "max-frequency" instead of > >>>>> "clock-freq-min-max". > >>>>> > >>>>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> > >>>>> --- > >>>>> > >>>>> arch/arm/boot/dts/exynos3250-artik5-eval.dts | 2 +- > >>>>> arch/arm/boot/dts/exynos3250-artik5.dtsi | 2 +- > >>>>> arch/arm/boot/dts/exynos3250-monk.dts | 2 +- > >>>>> arch/arm/boot/dts/exynos3250-rinato.dts | 2 +- > >>>>> 4 files changed, 4 insertions(+), 4 deletions(-) > >>>> > >>>> This looks totally independent to rest of patches so it can be applied > >>>> separately without any functional impact (except lack of minimum > >>>> frequency). Is that correct? > >>> > >>> You're right. I will split the patches. And will resend. > >>> Thanks! > >> > >> I think what Krzysztof was asking was just if he can simply pick up this patch > >> alone, as it does not require any of the previous changes. > >> > >> Same is true for the Rockchip patches I guess, so we could just take them > >> individually into samsung/rockchip dts branches. > > > > Yes, I wanted to get exactly this information. I couldn't find it in > > cover letter. > > In drivers/mmc/core/host.c, there already is "max-frequency" property. > It's same functionality with "clock-freq-min-max". > Minimum clock value can be fixed to 100K. because MMC core will check clock value from 400K to 100K. > But max-frequency can be difference. > If we can use "max-frequency" property, we don't need to use "clock-freq-min-max" property anymore. > I will resend the deprecated property instead of removing "clock-freq-min-max". > > If you want to pick this, it's possible to pick. Then i will resend the patches without dt patches. Thanks, applied. Best regards, Krzysztof
diff --git a/arch/arm/boot/dts/exynos3250-artik5-eval.dts b/arch/arm/boot/dts/exynos3250-artik5-eval.dts index be4d6aa..4bd2ee8 100644 --- a/arch/arm/boot/dts/exynos3250-artik5-eval.dts +++ b/arch/arm/boot/dts/exynos3250-artik5-eval.dts @@ -28,7 +28,7 @@ vqmmc-supply = <&ldo3_reg>; card-detect-delay = <200>; clock-frequency = <100000000>; - clock-freq-min-max = <400000 100000000>; + max-frequency = <100000000>; samsung,dw-mshc-ciu-div = <1>; samsung,dw-mshc-sdr-timing = <0 1>; samsung,dw-mshc-ddr-timing = <1 2>; diff --git a/arch/arm/boot/dts/exynos3250-artik5.dtsi b/arch/arm/boot/dts/exynos3250-artik5.dtsi index a70819b..59c89d7 100644 --- a/arch/arm/boot/dts/exynos3250-artik5.dtsi +++ b/arch/arm/boot/dts/exynos3250-artik5.dtsi @@ -310,7 +310,7 @@ card-detect-delay = <200>; vmmc-supply = <&ldo12_reg>; clock-frequency = <100000000>; - clock-freq-min-max = <400000 100000000>; + max-frequency = <100000000>; samsung,dw-mshc-ciu-div = <1>; samsung,dw-mshc-sdr-timing = <0 1>; samsung,dw-mshc-ddr-timing = <1 2>; diff --git a/arch/arm/boot/dts/exynos3250-monk.dts b/arch/arm/boot/dts/exynos3250-monk.dts index 66f04f6..cccfe4b 100644 --- a/arch/arm/boot/dts/exynos3250-monk.dts +++ b/arch/arm/boot/dts/exynos3250-monk.dts @@ -435,7 +435,7 @@ card-detect-delay = <200>; vmmc-supply = <&vemmc_reg>; clock-frequency = <100000000>; - clock-freq-min-max = <400000 100000000>; + max-frequency = <100000000>; samsung,dw-mshc-ciu-div = <1>; samsung,dw-mshc-sdr-timing = <0 1>; samsung,dw-mshc-ddr-timing = <1 2>; diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts index 3967ee5..548413e 100644 --- a/arch/arm/boot/dts/exynos3250-rinato.dts +++ b/arch/arm/boot/dts/exynos3250-rinato.dts @@ -649,7 +649,7 @@ card-detect-delay = <200>; vmmc-supply = <&ldo12_reg>; clock-frequency = <100000000>; - clock-freq-min-max = <400000 100000000>; + max-frequency = <100000000>; samsung,dw-mshc-ciu-div = <1>; samsung,dw-mshc-sdr-timing = <0 1>; samsung,dw-mshc-ddr-timing = <1 2>;
In drivers/mmc/core/host.c, there is "max-frequency" property. It should be same behavior. So Use the "max-frequency" instead of "clock-freq-min-max". Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> --- arch/arm/boot/dts/exynos3250-artik5-eval.dts | 2 +- arch/arm/boot/dts/exynos3250-artik5.dtsi | 2 +- arch/arm/boot/dts/exynos3250-monk.dts | 2 +- arch/arm/boot/dts/exynos3250-rinato.dts | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)