| Message ID | 20161105143515.4668-1-xypron.glpk@gmx.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 11/05/2016 03:35 PM, Heinrich Schuchardt wrote: > for_each_property_of_node(pins, pp) checks that pp is not NULL. > So there is no need to check it inside the loop. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > --- > drivers/pinctrl/pinctrl-st.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c > index 8308f15..676efcc 100644 > --- a/drivers/pinctrl/pinctrl-st.c > +++ b/drivers/pinctrl/pinctrl-st.c > @@ -1181,7 +1181,7 @@ static int st_pctl_dt_parse_groups(struct device_node *np, > if (!strcmp(pp->name, "name")) > continue; > > - if (pp && (pp->length/sizeof(__be32)) >= OF_GPIO_ARGS_MIN) { > + if (pp->length / sizeof(__be32) >= OF_GPIO_ARGS_MIN) { > npins++; > } else { > pr_warn("Invalid st,pins in %s node\n", np->name); > Hi Heinrich Acked-by: Patrice Chotard <patrice.chotard@st.com> Thanks
On Sat, Nov 5, 2016 at 3:35 PM, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote: > for_each_property_of_node(pins, pp) checks that pp is not NULL. > So there is no need to check it inside the loop. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> Patch applied with Patrice's ACK. Yours, Linus Walleij
diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c index 8308f15..676efcc 100644 --- a/drivers/pinctrl/pinctrl-st.c +++ b/drivers/pinctrl/pinctrl-st.c @@ -1181,7 +1181,7 @@ static int st_pctl_dt_parse_groups(struct device_node *np, if (!strcmp(pp->name, "name")) continue; - if (pp && (pp->length/sizeof(__be32)) >= OF_GPIO_ARGS_MIN) { + if (pp->length / sizeof(__be32) >= OF_GPIO_ARGS_MIN) { npins++; } else { pr_warn("Invalid st,pins in %s node\n", np->name);
for_each_property_of_node(pins, pp) checks that pp is not NULL. So there is no need to check it inside the loop. Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> --- drivers/pinctrl/pinctrl-st.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)