| Message ID | 1478517229-140028-5-git-send-email-guangrong.xiao@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Nov 07, 2016 at 07:13:39PM +0800, Xiao Guangrong wrote: > as it is never called when nvdimm hotplug happens > > Suggested-by: Igor Mammedov <imammedo@redhat.com> > Signed-off-by: Xiao Guangrong <guangrong.xiao@linux.intel.com> > --- > hw/i386/pc.c | 6 ------ > 1 file changed, 6 deletions(-) Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
On Mon, 7 Nov 2016 19:13:39 +0800 Xiao Guangrong <guangrong.xiao@linux.intel.com> wrote: > as it is never called when nvdimm hotplug happens > > Suggested-by: Igor Mammedov <imammedo@redhat.com> > Signed-off-by: Xiao Guangrong <guangrong.xiao@linux.intel.com> Reviewed-by: Igor Mammedov <imammedo@redhat.com> > --- > hw/i386/pc.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/hw/i386/pc.c b/hw/i386/pc.c > index 8ef3920..97e23c4 100644 > --- a/hw/i386/pc.c > +++ b/hw/i386/pc.c > @@ -1761,12 +1761,6 @@ static void pc_dimm_unplug(HotplugHandler *hotplug_dev, > HotplugHandlerClass *hhc; > Error *local_err = NULL; > > - if (object_dynamic_cast(OBJECT(dev), TYPE_NVDIMM)) { > - error_setg(&local_err, > - "nvdimm device hot unplug is not supported yet."); > - goto out; > - } > - > hhc = HOTPLUG_HANDLER_GET_CLASS(pcms->acpi_dev); > hhc->unplug(HOTPLUG_HANDLER(pcms->acpi_dev), dev, &local_err); >
diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 8ef3920..97e23c4 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -1761,12 +1761,6 @@ static void pc_dimm_unplug(HotplugHandler *hotplug_dev, HotplugHandlerClass *hhc; Error *local_err = NULL; - if (object_dynamic_cast(OBJECT(dev), TYPE_NVDIMM)) { - error_setg(&local_err, - "nvdimm device hot unplug is not supported yet."); - goto out; - } - hhc = HOTPLUG_HANDLER_GET_CLASS(pcms->acpi_dev); hhc->unplug(HOTPLUG_HANDLER(pcms->acpi_dev), dev, &local_err);
as it is never called when nvdimm hotplug happens Suggested-by: Igor Mammedov <imammedo@redhat.com> Signed-off-by: Xiao Guangrong <guangrong.xiao@linux.intel.com> --- hw/i386/pc.c | 6 ------ 1 file changed, 6 deletions(-)