diff mbox

make intel_chipset.h public

Message ID 1477625883-76387-1-git-send-email-gurchetansingh@chromium.org (mailing list archive)
State New, archived
Headers show

Commit Message

Gurchetan Singh Oct. 28, 2016, 3:38 a.m. UTC
This file has useful information regarding the pci-id --> gen
conversion.  The gen determines which scanout formats a chipset
supports (for example, the SKL display engine can scanout Y-tiled
formats).  This would be useful for the ozone-gbm interface.

Signed-off-by: Gurchetan Singh <gurchetansingh@chromium.org>
---
 intel/Makefile.sources | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Emil Velikov Nov. 10, 2016, 6:47 p.m. UTC | #1
On 28 October 2016 at 04:38, Gurchetan Singh
<gurchetansingh@chromium.org> wrote:
> This file has useful information regarding the pci-id --> gen
> conversion.  The gen determines which scanout formats a chipset
> supports (for example, the SKL display engine can scanout Y-tiled
> formats).  This would be useful for the ozone-gbm interface.
>
It sounds like you're interested in the actual generation rather than
the exact device id, correct ?

If so an interface like [1] sounds be a better fit. I've poked Chris
about moving it to libdrm_intel so that others can also use it [2].
Guessing he did not have much time about that :-\

Thanks
Emil
[1] https://cgit.freedesktop.org/drm/igt-gpu-tools/commit/?id=d308bb082d429eb25dfd2844bcbafe722660a1ff
[2] https://patchwork.freedesktop.org/patch/95531/
Gurchetan Singh Nov. 11, 2016, 1:14 a.m. UTC | #2
Yes, I am interested in the generation.  Since DRM_IOCTL_I915_GETPARAM
returns the pci_id, a common place to get the generation would be nice.
Intel folks, where do you think would be the best place to put this
(libdrm_intel or the kernel)??

On Thu, Nov 10, 2016 at 10:47 AM, Emil Velikov <emil.l.velikov@gmail.com>
wrote:

> On 28 October 2016 at 04:38, Gurchetan Singh
> <gurchetansingh@chromium.org> wrote:
> > This file has useful information regarding the pci-id --> gen
> > conversion.  The gen determines which scanout formats a chipset
> > supports (for example, the SKL display engine can scanout Y-tiled
> > formats).  This would be useful for the ozone-gbm interface.
> >
> It sounds like you're interested in the actual generation rather than
> the exact device id, correct ?
>
> If so an interface like [1] sounds be a better fit. I've poked Chris
> about moving it to libdrm_intel so that others can also use it [2].
> Guessing he did not have much time about that :-\
>
> Thanks
> Emil
> [1] https://cgit.freedesktop.org/drm/igt-gpu-tools/commit/?id=d3
> 08bb082d429eb25dfd2844bcbafe722660a1ff
> [2] https://patchwork.freedesktop.org/patch/95531/
>
diff mbox

Patch

diff --git a/intel/Makefile.sources b/intel/Makefile.sources
index 7b2272c..06f3acf 100644
--- a/intel/Makefile.sources
+++ b/intel/Makefile.sources
@@ -4,11 +4,11 @@  LIBDRM_INTEL_FILES := \
 	intel_bufmgr_fake.c \
 	intel_bufmgr_gem.c \
 	intel_decode.c \
-	intel_chipset.h \
 	mm.c \
 	mm.h
 
 LIBDRM_INTEL_H_FILES := \
 	intel_bufmgr.h \
 	intel_aub.h \
-	intel_debug.h
+	intel_debug.h \
+	intel_chipset.h