| Message ID | 1478945832-1826-1-git-send-email-alim.akhtar@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hello Alim, On 11/12/2016 07:17 AM, Alim Akhtar wrote: > This patch adds level for cpu dt node, so that these levels can be used Do you mean s/level/label here? I'm asking because you are using level consistently in the subject line and commit message but I'm not sure what it means in this context. > as a phandle whenever required. For example, adding a "interrupt-affinity" > for arm pmu node. > > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> > --- The change looks good to me though. Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> Best regards,
Hi Javier, On Sat, Nov 12, 2016 at 7:54 PM, Javier Martinez Canillas <javier@osg.samsung.com> wrote: > Hello Alim, > > On 11/12/2016 07:17 AM, Alim Akhtar wrote: >> This patch adds level for cpu dt node, so that these levels can be used > > Do you mean s/level/label here? I'm asking because you are using level > consistently in the subject line and commit message but I'm not sure > what it means in this context. > Ah!! my bad. Its __label__. If required, will respin. Thanks for review. >> as a phandle whenever required. For example, adding a "interrupt-affinity" >> for arm pmu node. >> >> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> >> --- > > The change looks good to me though. > > Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> > > Best regards, > -- > Javier Martinez Canillas > Open Source Group > Samsung Research America > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sat, Nov 12, 2016 at 6:00 PM, Alim Akhtar <alim.akhtar@gmail.com> wrote: > Hi Javier, > > On Sat, Nov 12, 2016 at 7:54 PM, Javier Martinez Canillas > <javier@osg.samsung.com> wrote: >> Hello Alim, >> >> On 11/12/2016 07:17 AM, Alim Akhtar wrote: >>> This patch adds level for cpu dt node, so that these levels can be used >> >> Do you mean s/level/label here? I'm asking because you are using level >> consistently in the subject line and commit message but I'm not sure >> what it means in this context. >> > > Ah!! my bad. Its __label__. If required, will respin. > Thanks for review. I think there is no need of respin because this should be squashed with previous patch. This is quite small and there are no functional changes here (labels are transparent, except of course conflict cases). Without the 2/2, this patch does not have much sense yet. Best regards, Krzysztof
Hi Krzysztof, On 11/13/2016 12:43 AM, Krzysztof Kozlowski wrote: > On Sat, Nov 12, 2016 at 6:00 PM, Alim Akhtar <alim.akhtar@gmail.com> wrote: >> Hi Javier, >> >> On Sat, Nov 12, 2016 at 7:54 PM, Javier Martinez Canillas >> <javier@osg.samsung.com> wrote: >>> Hello Alim, >>> >>> On 11/12/2016 07:17 AM, Alim Akhtar wrote: >>>> This patch adds level for cpu dt node, so that these levels can be used >>> >>> Do you mean s/level/label here? I'm asking because you are using level >>> consistently in the subject line and commit message but I'm not sure >>> what it means in this context. >>> >> >> Ah!! my bad. Its __label__. If required, will respin. >> Thanks for review. > > I think there is no need of respin because this should be squashed > with previous patch. This is quite small and there are no functional > changes here (labels are transparent, except of course conflict > cases). Without the 2/2, this patch does not have much sense yet. > The reason why I kept the _label_ changes are separate patch is to keep git bisect happy. If you think there won't be a case for that, then lets merge the two in single patch. Let me know if you want me to respin or you will take care. > Best regards, > Krzysztof > > >
diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi b/arch/arm64/boot/dts/exynos/exynos7.dtsi index e0d0d01..396ffb9 100644 --- a/arch/arm64/boot/dts/exynos/exynos7.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi @@ -35,28 +35,28 @@ #address-cells = <1>; #size-cells = <0>; - cpu@0 { + cpu_atlas0: cpu@0 { device_type = "cpu"; compatible = "arm,cortex-a57", "arm,armv8"; reg = <0x0>; enable-method = "psci"; }; - cpu@1 { + cpu_atlas1: cpu@1 { device_type = "cpu"; compatible = "arm,cortex-a57", "arm,armv8"; reg = <0x1>; enable-method = "psci"; }; - cpu@2 { + cpu_atlas2: cpu@2 { device_type = "cpu"; compatible = "arm,cortex-a57", "arm,armv8"; reg = <0x2>; enable-method = "psci"; }; - cpu@3 { + cpu_atlas3: cpu@3 { device_type = "cpu"; compatible = "arm,cortex-a57", "arm,armv8"; reg = <0x3>;
This patch adds level for cpu dt node, so that these levels can be used as a phandle whenever required. For example, adding a "interrupt-affinity" for arm pmu node. Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> --- arch/arm64/boot/dts/exynos/exynos7.dtsi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)