diff mbox

usb: musb: omap2430: use dev_err

Message ID 20161109140914.GE20859@localhost.localdomain (mailing list archive)
State New, archived
Headers show

Commit Message

Ladislav Michl Nov. 9, 2016, 2:09 p.m. UTC
Replace pr_err with dev_err to print also device name.

Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
---
 drivers/usb/musb/omap2430.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Tony Lindgren Nov. 9, 2016, 5:48 p.m. UTC | #1
* Ladislav Michl <ladis@linux-mips.org> [161109 07:09]:
> Replace pr_err with dev_err to print also device name.
> 
> Signed-off-by: Ladislav Michl <ladis@linux-mips.org>

Acked-by: Tony Lindgren <tony@atomide.com>

> ---
>  drivers/usb/musb/omap2430.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c
> index cc12254..451b372 100644
> --- a/drivers/usb/musb/omap2430.c
> +++ b/drivers/usb/musb/omap2430.c
> @@ -277,12 +277,12 @@ static int omap2430_musb_init(struct musb *musb)
>  		if (status == -ENXIO)
>  			return status;
>  
> -		pr_err("HS USB OTG: no transceiver configured\n");
> +		dev_err(dev, "HS USB OTG: no transceiver configured\n");
>  		return -EPROBE_DEFER;
>  	}
>  
>  	if (IS_ERR(musb->phy)) {
> -		pr_err("HS USB OTG: no PHY configured\n");
> +		dev_err(dev, "HS USB OTG: no PHY configured\n");
>  		return PTR_ERR(musb->phy);
>  	}
>  	musb->isr = omap2430_musb_interrupt;
> @@ -301,7 +301,7 @@ static int omap2430_musb_init(struct musb *musb)
>  
>  	musb_writel(musb->mregs, OTG_INTERFSEL, l);
>  
> -	pr_debug("HS USB OTG: revision 0x%x, sysconfig 0x%02x, "
> +	dev_dbg(dev, "HS USB OTG: revision 0x%x, sysconfig 0x%02x, "
>  			"sysstatus 0x%x, intrfsel 0x%x, simenable  0x%x\n",
>  			musb_readl(musb->mregs, OTG_REVISION),
>  			musb_readl(musb->mregs, OTG_SYSCONFIG),
> -- 
> 2.1.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Bin Liu Nov. 15, 2016, 9:13 p.m. UTC | #2
On Wed, Nov 09, 2016 at 10:48:25AM -0700, Tony Lindgren wrote:
> * Ladislav Michl <ladis@linux-mips.org> [161109 07:09]:
> > Replace pr_err with dev_err to print also device name.
> > 
> > Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
> 
> Acked-by: Tony Lindgren <tony@atomide.com>

Applied. Thanks.
-Bin.

> 
> > ---
> >  drivers/usb/musb/omap2430.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c
> > index cc12254..451b372 100644
> > --- a/drivers/usb/musb/omap2430.c
> > +++ b/drivers/usb/musb/omap2430.c
> > @@ -277,12 +277,12 @@ static int omap2430_musb_init(struct musb *musb)
> >  		if (status == -ENXIO)
> >  			return status;
> >  
> > -		pr_err("HS USB OTG: no transceiver configured\n");
> > +		dev_err(dev, "HS USB OTG: no transceiver configured\n");
> >  		return -EPROBE_DEFER;
> >  	}
> >  
> >  	if (IS_ERR(musb->phy)) {
> > -		pr_err("HS USB OTG: no PHY configured\n");
> > +		dev_err(dev, "HS USB OTG: no PHY configured\n");
> >  		return PTR_ERR(musb->phy);
> >  	}
> >  	musb->isr = omap2430_musb_interrupt;
> > @@ -301,7 +301,7 @@ static int omap2430_musb_init(struct musb *musb)
> >  
> >  	musb_writel(musb->mregs, OTG_INTERFSEL, l);
> >  
> > -	pr_debug("HS USB OTG: revision 0x%x, sysconfig 0x%02x, "
> > +	dev_dbg(dev, "HS USB OTG: revision 0x%x, sysconfig 0x%02x, "
> >  			"sysstatus 0x%x, intrfsel 0x%x, simenable  0x%x\n",
> >  			musb_readl(musb->mregs, OTG_REVISION),
> >  			musb_readl(musb->mregs, OTG_SYSCONFIG),
> > -- 
> > 2.1.4
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c
index cc12254..451b372 100644
--- a/drivers/usb/musb/omap2430.c
+++ b/drivers/usb/musb/omap2430.c
@@ -277,12 +277,12 @@  static int omap2430_musb_init(struct musb *musb)
 		if (status == -ENXIO)
 			return status;
 
-		pr_err("HS USB OTG: no transceiver configured\n");
+		dev_err(dev, "HS USB OTG: no transceiver configured\n");
 		return -EPROBE_DEFER;
 	}
 
 	if (IS_ERR(musb->phy)) {
-		pr_err("HS USB OTG: no PHY configured\n");
+		dev_err(dev, "HS USB OTG: no PHY configured\n");
 		return PTR_ERR(musb->phy);
 	}
 	musb->isr = omap2430_musb_interrupt;
@@ -301,7 +301,7 @@  static int omap2430_musb_init(struct musb *musb)
 
 	musb_writel(musb->mregs, OTG_INTERFSEL, l);
 
-	pr_debug("HS USB OTG: revision 0x%x, sysconfig 0x%02x, "
+	dev_dbg(dev, "HS USB OTG: revision 0x%x, sysconfig 0x%02x, "
 			"sysstatus 0x%x, intrfsel 0x%x, simenable  0x%x\n",
 			musb_readl(musb->mregs, OTG_REVISION),
 			musb_readl(musb->mregs, OTG_SYSCONFIG),