Message ID | 1479099731-28108-9-git-send-email-pankaj.dubey@samsung.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On 14/11/16 05:02, Pankaj Dubey wrote: > Now as we have of_scu_enable which takes care of mapping > scu base from DT, lets use it. > > CC: Liviu Dudau <liviu.dudau@arm.com> > CC: Sudeep Holla <sudeep.holla@arm.com> I assume you will take this series through a single tree. Also I assume you may make changes around a9 SCU. I will try to test if I can get my setup back working. But if this patch is not changed, then Acked-by: Sudeep Holla <sudeep.holla@arm.com>
Hi Sudeep, On Wednesday 16 November 2016 08:04 PM, Sudeep Holla wrote: > > > On 14/11/16 05:02, Pankaj Dubey wrote: >> Now as we have of_scu_enable which takes care of mapping >> scu base from DT, lets use it. >> >> CC: Liviu Dudau <liviu.dudau@arm.com> >> CC: Sudeep Holla <sudeep.holla@arm.com> > > I assume you will take this series through a single tree. Also I assume > you may make changes around a9 SCU. I will try to test if I can get my > setup back working. But if this patch is not changed, then > > Acked-by: Sudeep Holla <sudeep.holla@arm.com> Thanks for review and Ack. Yes, plan is to take this series through a single tree. As there are few comments for other platforms and common scu file, I will address them and submit v2 of this series soon. But I can see there won't be any changes for vexpress platform patch in v2, so I will include your Ack. Thanks, Pankaj Dubey
diff --git a/arch/arm/mach-vexpress/platsmp.c b/arch/arm/mach-vexpress/platsmp.c index 8b8d072..17dee2b 100644 --- a/arch/arm/mach-vexpress/platsmp.c +++ b/arch/arm/mach-vexpress/platsmp.c @@ -41,20 +41,9 @@ bool __init vexpress_smp_init_ops(void) return false; } -static const struct of_device_id vexpress_smp_dt_scu_match[] __initconst = { - { .compatible = "arm,cortex-a5-scu", }, - { .compatible = "arm,cortex-a9-scu", }, - {} -}; - static void __init vexpress_smp_dt_prepare_cpus(unsigned int max_cpus) { - struct device_node *scu = of_find_matching_node(NULL, - vexpress_smp_dt_scu_match); - - if (scu) - scu_enable(of_iomap(scu, 0)); - + of_scu_enable(); /* * Write the address of secondary startup into the * system-wide flags register. The boot monitor waits
Now as we have of_scu_enable which takes care of mapping scu base from DT, lets use it. CC: Liviu Dudau <liviu.dudau@arm.com> CC: Sudeep Holla <sudeep.holla@arm.com> CC: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> --- arch/arm/mach-vexpress/platsmp.c | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-)