| Message ID | 20161117185237.7070-1-f.fainelli@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, 17 Nov 2016 19:52:37 +0100, Florian Fainelli wrote: > > Architectures like m32r do not have a proper DMA-API implementation, > fixes COMPILE_TEST linking failures for the sounds subsystem. What error did you get exactly? There are already CONFIG_HAS_DMA dependency in a few places, so I wonder what's missing. thanks, Takashi > > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> > --- > sound/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/Kconfig b/sound/Kconfig > index 5a240e050ae6..a768704d2f47 100644 > --- a/sound/Kconfig > +++ b/sound/Kconfig > @@ -60,6 +60,7 @@ if !M68K && !UML > > menuconfig SND > tristate "Advanced Linux Sound Architecture" > + depends on HAS_DMA > help > Say 'Y' or 'M' to enable ALSA (Advanced Linux Sound Architecture), > the new base sound system. > -- > 2.9.3 > >
On 11/17/2016 11:03 AM, Takashi Iwai wrote: > On Thu, 17 Nov 2016 19:52:37 +0100, > Florian Fainelli wrote: >> >> Architectures like m32r do not have a proper DMA-API implementation, >> fixes COMPILE_TEST linking failures for the sounds subsystem. > > What error did you get exactly? > There are already CONFIG_HAS_DMA dependency in a few places, so I > wonder what's missing. They looked like these: sound/built-in.o: In function `snd_pcm_lib_default_mmap': (.text+0xbb14): undefined reference to `bad_dma_ops' sound/built-in.o: In function `snd_pcm_lib_default_mmap': (.text+0xbb1c): undefined reference to `bad_dma_ops' sound/built-in.o: In function `snd_pcm_lib_default_mmap': (.text+0xbb34): undefined reference to `dma_common_mmap' sound/built-in.o: In function `snd_pcm_lib_default_mmap': (.text+0xbb34): relocation truncated to fit: R_M32R_26_PCREL_RELA against undefined symbol `dma_common_mmap' Makefile:961: recipe for target 'vmlinux' failed I could probably add an ifdef CONFIG_HAS_DMA just surrounding these snd_pcm_lib if you think this is more appropriate?
On 11/17/2016 11:14 AM, Florian Fainelli wrote: > On 11/17/2016 11:03 AM, Takashi Iwai wrote: >> On Thu, 17 Nov 2016 19:52:37 +0100, >> Florian Fainelli wrote: >>> >>> Architectures like m32r do not have a proper DMA-API implementation, >>> fixes COMPILE_TEST linking failures for the sounds subsystem. >> >> What error did you get exactly? >> There are already CONFIG_HAS_DMA dependency in a few places, so I >> wonder what's missing. > > They looked like these: > > sound/built-in.o: In function `snd_pcm_lib_default_mmap': > (.text+0xbb14): undefined reference to `bad_dma_ops' > sound/built-in.o: In function `snd_pcm_lib_default_mmap': > (.text+0xbb1c): undefined reference to `bad_dma_ops' > sound/built-in.o: In function `snd_pcm_lib_default_mmap': > (.text+0xbb34): undefined reference to `dma_common_mmap' > sound/built-in.o: In function `snd_pcm_lib_default_mmap': > (.text+0xbb34): relocation truncated to fit: R_M32R_26_PCREL_RELA > against undefined symbol `dma_common_mmap' > Makefile:961: recipe for target 'vmlinux' failed > > I could probably add an ifdef CONFIG_HAS_DMA just surrounding these > snd_pcm_lib if you think this is more appropriate? I can't reproduce this build failure reliably anyway now, it was due to switching between x86/m32r configurations, the only offender was the Broadcom Cygnus driver, and this has been fixed as well. Sorry for the noise!
diff --git a/sound/Kconfig b/sound/Kconfig index 5a240e050ae6..a768704d2f47 100644 --- a/sound/Kconfig +++ b/sound/Kconfig @@ -60,6 +60,7 @@ if !M68K && !UML menuconfig SND tristate "Advanced Linux Sound Architecture" + depends on HAS_DMA help Say 'Y' or 'M' to enable ALSA (Advanced Linux Sound Architecture), the new base sound system.
Architectures like m32r do not have a proper DMA-API implementation, fixes COMPILE_TEST linking failures for the sounds subsystem. Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> --- sound/Kconfig | 1 + 1 file changed, 1 insertion(+)