| Message ID | 20161118161621.798004-2-arnd@arndb.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Arnd, On Fri, Nov 18, 2016 at 5:16 PM, Arnd Bergmann <arnd@arndb.de> wrote: > drivers/media/platform/rcar_fdp1.o: In function `fdp1_pm_runtime_resume': > rcar_fdp1.c:(.text.fdp1_pm_runtime_resume+0x78): undefined reference to `rcar_fcp_enable' > drivers/media/platform/rcar_fdp1.o: In function `fdp1_pm_runtime_suspend': > rcar_fdp1.c:(.text.fdp1_pm_runtime_suspend+0x14): undefined reference to `rcar_fcp_disable' > drivers/media/platform/rcar_fdp1.o: In function `fdp1_probe': > rcar_fdp1.c:(.text.fdp1_probe+0x15c): undefined reference to `rcar_fcp_get' > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/media/platform/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig > index 3c5a0b6b23a9..cd0cab6e0e31 100644 > --- a/drivers/media/platform/Kconfig > +++ b/drivers/media/platform/Kconfig > @@ -311,6 +311,7 @@ config VIDEO_RENESAS_FDP1 > tristate "Renesas Fine Display Processor" > depends on VIDEO_DEV && VIDEO_V4L2 && HAS_DMA > depends on ARCH_SHMOBILE || COMPILE_TEST > + depends on (!ARCH_RENESAS && !VIDEO_RENESAS_FCP) || VIDEO_RENESAS_FCP Which tree and config is this? I don't have fdp1_pm_runtime_resume in my renesas-drivers tree. Why are the dummies for !CONFIG_VIDEO_RENESAS_FCP in include/media/rcar-fcp.h not working? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Friday, November 18, 2016 6:08:01 PM CET Geert Uytterhoeven wrote: > > diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig > > index 3c5a0b6b23a9..cd0cab6e0e31 100644 > > --- a/drivers/media/platform/Kconfig > > +++ b/drivers/media/platform/Kconfig > > @@ -311,6 +311,7 @@ config VIDEO_RENESAS_FDP1 > > tristate "Renesas Fine Display Processor" > > depends on VIDEO_DEV && VIDEO_V4L2 && HAS_DMA > > depends on ARCH_SHMOBILE || COMPILE_TEST > > + depends on (!ARCH_RENESAS && !VIDEO_RENESAS_FCP) || VIDEO_RENESAS_FCP > > Which tree and config is this? I don't have fdp1_pm_runtime_resume in my > renesas-drivers tree. > > Why are the dummies for !CONFIG_VIDEO_RENESAS_FCP in include/media/rcar-fcp.h > not working? Oops, I forgot to write a proper changelog. Commit 4710b752e029 ("[media] v4l: Add Renesas R-Car FDP1 Driver") in the v4l-dvb tree adds CONFIG_VIDEO_RENESAS_FDP1. It calls into the FCP driver, but when there is no dependency, FCP might be a module while FDP1 is built-in. We have the same logic in VIDEO_RENESAS_VSP1, which also depends on FCP not being a module when it is built-in itself. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig index 3c5a0b6b23a9..cd0cab6e0e31 100644 --- a/drivers/media/platform/Kconfig +++ b/drivers/media/platform/Kconfig @@ -311,6 +311,7 @@ config VIDEO_RENESAS_FDP1 tristate "Renesas Fine Display Processor" depends on VIDEO_DEV && VIDEO_V4L2 && HAS_DMA depends on ARCH_SHMOBILE || COMPILE_TEST + depends on (!ARCH_RENESAS && !VIDEO_RENESAS_FCP) || VIDEO_RENESAS_FCP select VIDEOBUF2_DMA_CONTIG select V4L2_MEM2MEM_DEV ---help---
drivers/media/platform/rcar_fdp1.o: In function `fdp1_pm_runtime_resume': rcar_fdp1.c:(.text.fdp1_pm_runtime_resume+0x78): undefined reference to `rcar_fcp_enable' drivers/media/platform/rcar_fdp1.o: In function `fdp1_pm_runtime_suspend': rcar_fdp1.c:(.text.fdp1_pm_runtime_suspend+0x14): undefined reference to `rcar_fcp_disable' drivers/media/platform/rcar_fdp1.o: In function `fdp1_probe': rcar_fdp1.c:(.text.fdp1_probe+0x15c): undefined reference to `rcar_fcp_get' Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/media/platform/Kconfig | 1 + 1 file changed, 1 insertion(+)